Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbbGUKEh (ORCPT ); Tue, 21 Jul 2015 06:04:37 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:48167 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753942AbbGUKEg (ORCPT ); Tue, 21 Jul 2015 06:04:36 -0400 Message-ID: <55AE192D.6020606@hitachi.com> Date: Tue, 21 Jul 2015 19:04:29 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Tom Zanussi , rostedt@goodmis.org CC: daniel.wagner@bmw-carit.de, namhyung@kernel.org, josh@joshtriplett.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 02/22] tracing: Make ftrace_event_field checking functions available References: <42c846bed4989ee48475e93aa6fa3bfb59f8e53e.1437066836.git.tom.zanussi@linux.intel.com> In-Reply-To: <42c846bed4989ee48475e93aa6fa3bfb59f8e53e.1437066836.git.tom.zanussi@linux.intel.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2670 Lines: 78 On 2015/07/17 2:22, Tom Zanussi wrote: > Make is_string_field() and is_function_field() accessible outside of > trace_event_filters.c for other users of ftrace_event_fields. > > Signed-off-by: Tom Zanussi BTW, is there any reason why we split this from caller-side change? this short change can be merged into the patch which actual requires this. Thanks, > --- > kernel/trace/trace.h | 12 ++++++++++++ > kernel/trace/trace_events_filter.c | 12 ------------ > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > index 4c41fcd..891c5b0 100644 > --- a/kernel/trace/trace.h > +++ b/kernel/trace/trace.h > @@ -1050,6 +1050,18 @@ struct filter_pred { > unsigned short right; > }; > > +static inline bool is_string_field(struct ftrace_event_field *field) > +{ > + return field->filter_type == FILTER_DYN_STRING || > + field->filter_type == FILTER_STATIC_STRING || > + field->filter_type == FILTER_PTR_STRING; > +} > + > +static inline bool is_function_field(struct ftrace_event_field *field) > +{ > + return field->filter_type == FILTER_TRACE_FN; > +} > + > extern enum regex_type > filter_parse_regex(char *buff, int len, char **search, int *not); > extern void print_event_filter(struct trace_event_file *file, > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index 71511eb..245ee5d 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -917,18 +917,6 @@ int filter_assign_type(const char *type) > return FILTER_OTHER; > } > > -static bool is_function_field(struct ftrace_event_field *field) > -{ > - return field->filter_type == FILTER_TRACE_FN; > -} > - > -static bool is_string_field(struct ftrace_event_field *field) > -{ > - return field->filter_type == FILTER_DYN_STRING || > - field->filter_type == FILTER_STATIC_STRING || > - field->filter_type == FILTER_PTR_STRING; > -} > - > static int is_legal_op(struct ftrace_event_field *field, int op) > { > if (is_string_field(field) && > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/