Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754780AbbGUKQO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jul 2015 06:16:14 -0400
Received: from smtp.citrix.com ([66.165.176.89]:1227 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754179AbbGUKQN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jul 2015 06:16:13 -0400
X-IronPort-AV: E=Sophos;i="5.15,515,1432598400"; 
   d="scan'208";a="282848425"
Message-ID: <55AE1BE7.5030102@citrix.com>
Date: Tue, 21 Jul 2015 12:16:07 +0200
From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Julien Grall <julien.grall@citrix.com>, <xen-devel@lists.xenproject.org>
CC: <linux-arm-kernel@lists.infradead.org>, <ian.campbell@citrix.com>,
        <stefano.stabellini@eu.citrix.com>, <linux-kernel@vger.kernel.org>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v2 06/20] block/xen-blkfront: Store a page rather a pfn
 in the grant structure
References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com>
 <1436474552-31789-7-git-send-email-julien.grall@citrix.com>
In-Reply-To: <1436474552-31789-7-git-send-email-julien.grall@citrix.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 992
Lines: 32

El 09/07/15 a les 22.42, Julien Grall ha escrit:
> All the usage of the field pfn are done using the same idiom:
> 
> pfn_to_page(grant->pfn)
> 
> This will  return always the same page. Store directly the page in the
> grant to clean up the code.
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

With one style fix.

[...]

>  static struct grant *get_grant(grant_ref_t *gref_head,
> -                               unsigned long pfn,
> +			       struct page *page,

Indentation.

Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/