Message-ID: <55AE2431.20105@mellanox.com>
Date: Tue, 21 Jul 2015 13:51:29 +0300
From: Haggai Eran <haggaie@mellanox.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>
CC: Christophe Harle <charle@nvidia.com>, Duncan Poole <dpoole@nvidia.com>,
        Sherry Cheung <SCheung@nvidia.com>, Subhash Gutti <sgutti@nvidia.com>,
        "John Hubbard" <jhubbard@nvidia.com>,
        Mark Hairgrove <mhairgrove@nvidia.com>,
        Lucien Dunning <ldunning@nvidia.com>,
        Cameron Buschardt <cabuschardt@nvidia.com>,
        Arvind Gopalakrishnan <arvindg@nvidia.com>,
        "Shachar Raindel" <raindel@mellanox.com>,
        Liran Liss <liranl@mellanox.com>
Subject: Re: [PATCH 6/8] IB/mlx5/hmm: add mlx5 HMM device initialization and
 callback v3.
References: <1437159665-6612-1-git-send-email-jglisse@redhat.com>
 <1437159665-6612-7-git-send-email-jglisse@redhat.com>
In-Reply-To: <1437159665-6612-7-git-send-email-jglisse@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
DB3PR05MB459: X-MS-Exchange-Organization-RulesExecuted
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2015 10:52:31.7399
 (UTC)
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR05MB459
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1407
Lines: 34

On 17/07/2015 22:01, Jérôme Glisse wrote:
> @@ -151,10 +151,11 @@ int ib_umem_odp_get(struct ib_ucontext *context, struct ib_umem *umem)
>  		context->ib_mirror = ib_mirror_ref(ib_mirror);
>  	}
>  	mutex_unlock(&ib_device->hmm_mutex);
> -	umem->odp_data.ib_mirror = ib_mirror;
> +	umem->odp_data->ib_mirror = ib_mirror;
>  
>  	down_write(&ib_mirror->umem_rwsem);
> -	rbt_ib_umem_insert(&umem->odp_data->interval_tree, &mirror->umem_tree);
> +	rbt_ib_umem_insert(&umem->odp_data->interval_tree,
> +			   &ib_mirror->umem_tree);
>  	up_write(&ib_mirror->umem_rwsem);
>  
>  	mmput(mm);
> @@ -163,7 +164,7 @@ int ib_umem_odp_get(struct ib_ucontext *context, struct ib_umem *umem)
>  
>  void ib_umem_odp_release(struct ib_umem *umem)
>  {
> -	struct ib_mirror *ib_mirror = umem->odp_data;
> +	struct ib_mirror *ib_mirror = umem->odp_data->ib_mirror;
>  
>  	/*
>  	 * Ensure that no more pages are mapped in the umem.

It doesn't look like this code would have compiled before this patch,
and as far as I can see the previous patch removed the #error line.
Could you make sure all of the patches build correctly? You could use
tools/testing/ktest for instance.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/