Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbbGULUn (ORCPT ); Tue, 21 Jul 2015 07:20:43 -0400 Received: from smtp.citrix.com ([66.165.176.89]:35814 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbbGULUm (ORCPT ); Tue, 21 Jul 2015 07:20:42 -0400 X-IronPort-AV: E=Sophos;i="5.15,515,1432598400"; d="scan'208";a="282861627" Message-ID: <55AE2AC3.7070904@citrix.com> Date: Tue, 21 Jul 2015 12:19:31 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , CC: , , , David Vrabel , "Boris Ostrovsky" , Subject: Re: [Xen-devel] [PATCH v2 06/20] block/xen-blkfront: Store a page rather a pfn in the grant structure References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-7-git-send-email-julien.grall@citrix.com> <55AE1BE7.5030102@citrix.com> In-Reply-To: <55AE1BE7.5030102@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 48 Hi Roger, On 21/07/15 11:16, Roger Pau Monné wrote: > El 09/07/15 a les 22.42, Julien Grall ha escrit: >> All the usage of the field pfn are done using the same idiom: >> >> pfn_to_page(grant->pfn) >> >> This will return always the same page. Store directly the page in the >> grant to clean up the code. >> >> Signed-off-by: Julien Grall >> Cc: Konrad Rzeszutek Wilk >> Cc: Roger Pau Monné >> Cc: Boris Ostrovsky >> Cc: David Vrabel > > Acked-by: Roger Pau Monné > > With one style fix. > > [...] > >> static struct grant *get_grant(grant_ref_t *gref_head, >> - unsigned long pfn, >> + struct page *page, > > Indentation. The indentation for the parameters of this function wasn't correct: static struct grant *get_grant(grant_ref_t *gref_head, - unsigned long pfn, +^I^I^I struct page *page, struct blkfront_info *info) So "struct page *page" is correctly indent but not the remaining parameter ("struct blkfront_info *info"). I will indent it correctly. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/