Date: Tue, 21 Jul 2015 07:04:53 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Michal Marek <mmarek@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
        x86@kernel.org, live-patching@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] x86/stackvalidate: Compile-time stack validation
Message-ID: <20150721120453.GA11122@treble.redhat.com>
References: <cover.1436893563.git.jpoimboe@redhat.com>
 <c6ce1f45365e13dad73d4a04e100921b79794690.1436893563.git.jpoimboe@redhat.com>
 <CADWwUUZkfRL2RpGF3D-gjZjtLwrg=ip4duBqCTYV8jT8bQoNXA@mail.gmail.com>
 <20150720175026.GC28075@treble.redhat.com>
 <20150721080203.GB26811@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150721080203.GB26811@gmail.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1664
Lines: 53

On Tue, Jul 21, 2015 at 10:02:03AM +0200, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> 
> > > > +int main(int argc, char *argv[])
> > > > +{
> > > > +       struct elf *elf;
> > > > +       int ret = 0, warnings = 0;
> > > > +
> > > > +       argp_parse(&argp, argc, argv, 0, 0, &args);
> > > > +
> > > > +       elf = elf_open(args.args[0]);
> > > > +       if (!elf) {
> > > > +               fprintf(stderr, "error reading elf file %s\n", args.args[0]);
> > > > +               return 1;
> > > > +       }
> > > > +
> > > > +       ret = decode_sections(elf);
> > > > +       if (ret < 0)
> > > > +               goto out;
> > > > +       warnings += ret;
> > > > +
> > > > +       ret = validate_functions(elf);
> > > > +       if (ret < 0)
> > > > +               goto out;
> > > > +       warnings += ret;
> > > > +
> > > > +       ret = validate_uncallable_instructions(elf);
> > > > +       if (ret < 0)
> > > > +               goto out;
> > > > +       warnings += ret;
> > > > +
> > > > +out:
> > > 
> > > elf_close(elf);  ??
> > 
> > I intentionally left out the call to elf_close() here, since this is the
> > exit path and the kernel will free the memory anyway.
> 
> OTOH it makes Valgrind runs harder to interpret, as real leaks won't be visible.
> 
> So I'd only do intentional leaks only if it's truly, measurably improves 
> performance.

Ok.  I'll fix the leaks.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/