Date: Tue, 21 Jul 2015 19:26:26 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/2] drm/i915: remove unnecessary null test
Message-ID: <20150721135626.GA31093@sudip-PC>
References: <1437480406-19285-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20150721135140.GM16722@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150721135140.GM16722@phenom.ffwll.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1184
Lines: 29

On Tue, Jul 21, 2015 at 03:51:40PM +0200, Daniel Vetter wrote:
> On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote:
> > While creating the debugfs file we are setting the inode->i_private to
> > dev. That same dev is passed to these functions as private of struct
> > seq_file via single_open(). Moreover single_open is setting
> > file->private_data->private to dev.
> > So at this point it can never be NULL.
> > This check was added by commit eb3394faeb97 ("drm/i915: Add debugfs test
> > control files for Displayport compliance testing")
> > 
> 
> Still missing
> 
> Cc: Chris Wilson ...
> Cc: Todd Previte ...
> 
> here to make sure reviewers/original authors are in the loop. Anyway this
> is a simple enough patch, so I just pulled them both in.
Sorry. did you mean to put Cc: here before the Signed-off-by: ?
I have put them in Cc list of the patches.
For my next patch you will not get these issues.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/