Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932387AbbGUORK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jul 2015 10:17:10 -0400
Received: from mga03.intel.com ([134.134.136.65]:8557 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932124AbbGUORI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jul 2015 10:17:08 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,516,1432623600"; 
   d="scan'208";a="768354037"
Message-ID: <1437488226.22524.4.camel@tzanussi-mobl.amr.corp.intel.com>
Subject: Re: [PATCH v9 08/22] tracing: Add 'hist' event trigger command
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: rostedt@goodmis.org, daniel.wagner@bmw-carit.de, namhyung@kernel.org,
        josh@joshtriplett.org, andi@firstfloor.org,
        linux-kernel@vger.kernel.org
Date: Tue, 21 Jul 2015 09:17:06 -0500
In-Reply-To: <55ACF98A.9070307@hitachi.com>
References: <cover.1437066836.git.tom.zanussi@linux.intel.com>
	 <4912007a2c10ba09a34e5edafa7325377a4795d5.1437066836.git.tom.zanussi@linux.intel.com>
	 <55ACF98A.9070307@hitachi.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2485
Lines: 57

Hi Masami,

On Mon, 2015-07-20 at 22:37 +0900, Masami Hiramatsu wrote:
> Hi Tom,
> 
> On 2015/07/17 2:22, Tom Zanussi wrote:
> 
> > @@ -3782,6 +3785,32 @@ static const char readme_msg[] =
> >  	"\t   To remove a trigger with a count:\n"
> >  	"\t     echo '!<trigger>:0 > <system>/<event>/trigger\n"
> >  	"\t   Filters can be ignored when removing a trigger.\n"
> > +#ifdef CONFIG_HIST_TRIGGERS
> > +	"      hist trigger\t- If set, event hits are aggregated into a hash table\n"
> > +	"\t    Format: hist:keys=<field1>\n"
> > +	"\t            [:size=#entries]\n"
> > +	"\t            [if <filter>]\n\n"
> > +	"\t    When a matching event is hit, an entry is added to a hash\n"
> > +	"\t    table using the key named.  Keys correspond to fields in the\n"
> > +	"\t    event's format description.  On an event hit, the value of a\n"
> > +	"\t    sum called 'hitcount' is incremented, which is simply a count\n"
> > +	"\t    of event hits.  Keys can be any field.\n\n"
> > +	"\t    Reading the 'hist' file for the event will dump the hash\n"
> > +	"\t    table in its entirety to stdout.  Each printed hash table\n"
> > +	"\t    entry is a simple list of the keys and values comprising the\n"
> > +	"\t    entry; keys are printed first and are delineated by curly\n"
> > +	"\t    braces, and are followed by the set of value fields for the\n"
> > +	"\t    entry.  Numeric fields are displayed as base-10 integers.\n"
> > +	"\t    By default, the size of the hash table is 2048 entries.  The\n"
> > +	"\t    'size' param can be used to specify more or fewer than that.\n"
> > +	"\t    The units are in terms of hashtable entries - if a run uses\n"
> > +	"\t    more entries than specified, the results will show the number\n"
> > +	"\t    of 'drops', the number of hits that were ignored.  The size\n"
> > +	"\t    should be a power of 2 between 128 and 131072 (any non-\n"
> > +	"\t    power-of-2 number specified will be rounded up).\n\n"
> > +	"\t    The entries are sorted by 'hitcount' and the sort order is\n"
> > +	"\t    'ascending'.\n\n"
> 
> 
> Hmm, this seems too much about implementation of histogram. Could you shorten this
> to be a half ?
> 

OK, I'll try to cut it down to just usage essentials.

Tom

> 
> Thank you,
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/