Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755263AbbGUO4T (ORCPT ); Tue, 21 Jul 2015 10:56:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57024 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbbGUO4S (ORCPT ); Tue, 21 Jul 2015 10:56:18 -0400 Date: Tue, 21 Jul 2015 16:56:15 +0200 From: Jiri Olsa To: Namhyung Kim Cc: "Liang, Kan" , "acme@kernel.org" , "jolsa@kernel.org" , "ak@linux.intel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC V5 2/4] perf,tool: per-event time support Message-ID: <20150721145615.GB21171@krava.brq.redhat.com> References: <1437132655-15883-1-git-send-email-kan.liang@intel.com> <1437132655-15883-3-git-send-email-kan.liang@intel.com> <20150718124547.GA3759@krava.brq.redhat.com> <20150719032128.GA24219@danjae.kornet> <20150719191322.GA27893@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F0770188F5E9@SHSMSX103.ccr.corp.intel.com> <20150720174046.GA27331@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F0770188F94B@SHSMSX103.ccr.corp.intel.com> <20150721144501.GA10689@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150721144501.GA10689@danjae.kornet> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 35 On Tue, Jul 21, 2015 at 11:45:01PM +0900, Namhyung Kim wrote: SNIP > > > > > > [jolsa@krava perf]$ ./perf record -e 'cpu/instructions,period=20000/' -c > > > 1000 sleep 1 [ perf record: Woken up 1 times to write data ] /proc/kcore > > > requires CAP_SYS_RAWIO capability to access. > > > [ perf record: Captured and wrote 0.015 MB perf.data (35 samples) ] > > > [jolsa@krava perf]$ ./perf evlist -vv > > > cpu/instructions,period=20000/: type: 4, size: 112, config: 0xc0, > > > { sample_period, sample_freq }: 20000 > > > > > > > So you are going to change current behavior? > > The current behavior is "global opts setting" > "per_event settring" > default > > You are going to change it to "per_event settring" > "global opts setting" > > > Default. Right? > > Hmm.. I agree that changing current behavior is not good. But I think > it makes more sense to prefer per-event settings over global settings > in general. hum right.. but it's just period ATM that will be affected.. I'd risk it, since I dont think maybe people actualy used it ;-) together with time term, which wasn't possible to change before anyway, so there should be no problem jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/