Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932822AbbGUPRT (ORCPT ); Tue, 21 Jul 2015 11:17:19 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33652 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932160AbbGUPRQ (ORCPT ); Tue, 21 Jul 2015 11:17:16 -0400 Subject: Re: [PATCH 2/2] tracing: Introduce two additional marks for delay Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Jungseok Lee In-Reply-To: <20150721110944.6c3138ef@gandalf.local.home> Date: Wed, 22 Jul 2015 00:17:09 +0900 Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Byungchul Park Content-Transfer-Encoding: 7bit Message-Id: References: <1436626300-1679-1-git-send-email-jungseoklee85@gmail.com> <1436626300-1679-3-git-send-email-jungseoklee85@gmail.com> <4B29B132-6D19-475C-8E08-1232AAE8AD31@gmail.com> <20150721110944.6c3138ef@gandalf.local.home> To: Steven Rostedt X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 39 On Jul 22, 2015, at 12:09 AM, Steven Rostedt wrote: > On Tue, 21 Jul 2015 23:56:31 +0900 > Jungseok Lee wrote: > > > >> Recently, I've noticed that there is a minor, not logical, flaw in the >> above hunk as reviewing patches which do not get any signals yet. It is >> a lack of 's' in msec in comment. That is, my latest one is as follows. >> >> + MARK(100000000ULL , '@'), /* 100 msecs */ >> + MARK(10000000ULL , '*'), /* 10 msecs */ >> >> I know it's definitely trivial, but I've updated it to align with other >> comments and planned to resend the patch. Surprisingly, this patch >> has been already staged on your repo. So, I leave a whole patch again >> including your SOB since I don't know how to handle this. >> >> Thanks you for reviewing my patch! > > The original is in the process of going through my tests. I waited till > rc3 to come out to rebase all my work on it (including this patch) and > restated testing again. I tripped on some things that are still buggy > in -rc3 (which delays the finishing of my testing). > > As it is in the testing phase, I wont be modifying it. If you want, > just send another patch on top of my ftrace/core branch, and I can add > that to my queue too. Thanks for a kind explanation. I think it is not needed to create another patch for only this change. Best Regards Jungseok Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/