Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932777AbbGUP2p (ORCPT ); Tue, 21 Jul 2015 11:28:45 -0400 Received: from mail-bl2on0075.outbound.protection.outlook.com ([65.55.169.75]:32096 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932547AbbGUP2n (ORCPT ); Tue, 21 Jul 2015 11:28:43 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none; Date: Tue, 21 Jul 2015 10:22:38 -0500 From: Dinh Nguyen X-X-Sender: dinguyen@linux-builds1 To: Tyler Baker CC: Stephen Boyd , Mike Turquette , , , "linux-kernel@vger.kernel.org" , Maxime Ripard , =?ISO-8859-15?Q?Emilio_L=F3pez?= Subject: Re: [PATCHv2 5/6] clk: sunxi: make use of of_clk_parent_fill helper function In-Reply-To: Message-ID: References: <1436241546-16731-1-git-send-email-dinguyen@opensource.altera.com> <1436241546-16731-6-git-send-email-dinguyen@opensource.altera.com> <20150718005313.GE30412@codeaurora.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1899992832-1437492168=:22725" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR21CA0041.namprd21.prod.outlook.com (25.162.74.179) To BN3PR03MB1368.namprd03.prod.outlook.com (25.163.34.154) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1368;2:gfkBwqQcScVaULQBg7wOAznh6W/bEU1nIWAaSL1XDb6QMiBbpqkQHk6smlYo3oGm;3:CVR8jm/YQhuBLnCmWeM8rDxxbWoop5sfZvkW2lpw6DGuUl0Cm2DzERHyz28H5BGeRYS5HQVE7tdoMrf9alhZ5T4rdBCvxiJjKE93Dtm/FNncp4ulKHRdKylRCXT09+h9etmFz7+Bt4/0fz9dEZxzkQ==;25:NwoZYbWSMI0Jzy7gdnWAJ1yrl3JJ7IdftVRcox8Vol+B5heFWvMmco76gexpnGwW87q2l/xkNfe8znWuAu5Ko10Ndu/A/oi/mar4/RwgF+M6HBp8Ui26gB6xODX9ZFWiDSNa5xv4g4mgXB8EjhiZixvjyg2U6g1GNIxLpK7G1vvwyYtqj0lNehO1LgpkEu79rDYHJZlFEntce59QxPB5jrNLVZxnxIE16FRZQ8glU0b5TlPStW+2Z+PHDjEiHgAl0jgW622Y05oXbhHhjEd0aQ==;20:49AYm/k8IvHBzfsCRKRZFVWjgppOxRUF0pZ9MUsCtYfWu0Ig1HsFxWRj8t9z1L1cAgd/NIocarH/Pw4+T6e+fpayDF31mlVORewQUf6fLlSTkLIOnd233jEBpmZNoq2pzW0UfquxVYuIgIyhnMfXmNg1ythXvoueSrS8b6ZKWjE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1368;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB121; BN3PR03MB1368: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR03MB1368;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1368;BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1PR03MB121;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB121; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1368;4:05vUuYTVN/TjOAzRsllFNuVbecsnPrbj8M9tCcR39EAFHM7Q0CsCfS2lmFGf0127s39R3qe2HmJffNOsuBFRYgPuIcRnR7wLWtiZ/xRkfCUaT4Tu/2w7RKEMTQxh7DOeNFo0jk1eTDXbTeKNcArjke1aD47wy70UgMuIVY8yb4eJZgQt+l46img25hcLGIXNSLFrLPQeknffdVTg9zeGb2BRl3ubhL4ntuqg3zRPKplCDxl82/jIGz5ZZh4j/2AcsibZsaQEq5QNLVjITN98tVckZ/VtG2tJ+aWorc9RfSM= X-Forefront-PRVS: 0644578634 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(46102003)(4001350100001)(53416004)(84326002)(4610100001)(41446005)(33716001)(76176999)(77156002)(92566002)(42186005)(19580395003)(122386002)(86362001)(62966003)(19580405001)(110136002)(512874002)(40100003)(189998001)(87976001)(54356999)(66066001)(77096005)(50986999)(5001960100002)(2950100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1368;H:linux-builds1.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1368;23:xDoF9+wAaklN7R+SZQZoC2Q8Ur0f5zDn6JmEPhj6kHgNDtRENRb2i0li4RV6dca74/ro3+Aobg1N0h1AT93LB+243RweYGiGHDPftXC1PnTpBI8aQlpz8JmFulG07lW+7wa7SHdFbYRXwTW5d35TY3UKZZjFLuh014mNh85k5/J7gW/RN4dELLBMWIHQ7iM5gk72OPYZRUxfmC38LQQYtSSDugZrGRHJyWb4C7CoLVtnJHWzEFR3lOxTv+UAhLTQBYGvaqApbJpCQ44zx9VjxTUOrdXViZkC+Sb1y2Edhz3kdH5USK9XASxmNxc+SGbxBUftc0i/Tk5mOEJcoZ5UgSv0I2mcBfAMPLX4w3IF/CYIUDxxZUXdjM8+/OPz56XSPVKr2+LD5Kw+y+t3G1nhmQUoUDbZKt8loo7LbYLESBma8GZUY1FXmOiw3+4Na86Wco3BDm7EWtDm7xeVXKQpaDPRddYkEiLWbJInmurA4HPDU0z3utk1Hpv2NAmpj7VCFL0ZHixdPfD3n6KwwVPYDBkkCKY2gXtTRJX3ibt92b0yWY/GzsA6Tijogx9juU/tZPemHdhggPWxIji1tW7sjc6SCFjT7FIy2zQ/CROv8GdbH6DkG5qrfPOHgIDVDlxqnsL92C1vFRYh+KkI/zC2du1i/4DPTmAZTVMOBfClCEMByo1Hq0v4IfaXD/k4zthjQFxsWEmcPrOTnFlkselqL8dxbaOTC1W0fa0eWvAEs/WaFx9kG8VAbHML5u9rg5vojQBhDNn6vYwA/WZnlPjQWjtxCFr04zDCMQMNc7Sgv/huJ6CFCUD7gXtG3czp6EZa X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1368;5:zHjLr6RDyMXv/kFnV+SfYwyjTq8qWL0MrdPspMxFw2Lgbkf/zrqTyzv0ZXEqqqXR5/QI+3cd3YEZ+gAXuMEfBpO9lAHDbeKAn8HND+Tem6RY1+xZ896ZX0wF0pAYf6rYM+3nwevs6nP6sLAmQb7AXg==;24:j1TJSj2XMJJdZuI7LdczdmDSw8i4pj5+dinBX7pTntQh7KzPj1apNH0smmlqCuDzjzEqHXqiDgFAGnLx+yCO4iyFJKRYm/K76se79NUPJS4=;20:GhFcs4yYXzro1DOcl/x8U4P62WL95aVS4tYRd3Yo4KZOV8I1A73tUSMTQjAYJX2i3DRMEAHiDPFfNmf6UJnLPG6UDthknoD6hyH6/juz7ewvCktZYq6xxqaD25EH0/olSOkxTLRiS56DlFKdlv0GbdeWnfpQtJNtnPqHemyC9aQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1368 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11FD043.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD043;1:vKoRlvez8ulahgc6O7igKRUARD8IrJzUemArjSNgbyI0yGNqhSJW9+F+QVXf210NKQngUanvt4q250n1RSbSdJeeaVMiIANK+QbebVEvVMwp+jBxcJmh/4hk5B/CI+0kV0aHumGMz8o+Pcux9hrny5QDsnt7+xHdwq8462Onk8vV0eUO1oksTP6rfiQ5aDOYsTJCuU+V6GKa5qjCJZVxVmEl9ogduaZJvya9rPyzNTI7lnmUydthL///QFCB6CpKiWX0+utMyCoW0MCOiiK5PFhmxNnuZZH5s476xUBJsya3ItLvcsDIT/2gEfTOhw0fM8qGnhN4M90gVuqEtH1AhToPCw+6WCuUzkcMMawUHGc0t+PMEqaTREYZ/SuhyQaJWaszTvo7yC2X5FCmMhu5V+06u7CI0w7M16SKFv6bCuk= X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(339900001)(189002)(199003)(24454002)(86362001)(66066001)(46102003)(77156002)(105606002)(40100003)(62966003)(2950100001)(84326002)(53416004)(77096005)(189998001)(85426001)(110136002)(512874002)(5001960100002)(4001350100001)(106466001)(33716001)(54356999)(5001920100001)(19580395003)(6806004)(16796002)(19580405001)(87936001)(92566002)(4610100001)(76176999)(122386002)(41446005)(50986999)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB121;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB121;2:i+kIsx+/gFEvGs7fbdTqHTc41HMCIxQiL41Bo8pv2K8eDIT6bdTYmPd+st49QRPh;3:/2hSz4lidjXBq5S3TwjFGtNDdzTDblx/wFGAPVCPkOf/tDUwXEoW9Gog/FIl62bebYzIm4LadRFtVCGM/iBVa8/2vzcQkktkjx+0IC5FpvjYNG7AHD1Squ5sj3YaEssjNPq9ky3XCb1qDxthkclF/cZ0UR/heskAAL9dSDsoY2aCjKAikwKyOaS5EySS3zXiP/rpPibLQAJHZoUHrejf3KM9JVOYKRIeAn3htOIBrK8=;25:0V/hhxDrREONs/OUwgM0gjVPyO46bY5v0Cp7rLRC+KPGL7HmJ3uwdK39IRJLQOs74dZSwlSxbWjTTxpUg9+TummEp1SCf0F1pSApimjh0Duz/uXlwYfs7QL+5vEdTahST+eAoC6RQj+gcWDwkwcE5DeCLYYdrnZbA1SPIFOztzQ0c99Q3To5IZeUguvKRGdxv4rahqvQxcyTJ3npz+kW+0+sABtpvwSqbjoYna99cmppzvaj9KxtDSuB7mU3r3LqUlPJa40GZgAKRHHB12xXYg==;20:CJhROVTgpznLo3ie+3O+ca5r6M+J/ZDo+45ZqRk+3AtTgG0bJKuM/efvtzTaQK+eT5RiTBGs1jNJNBRWTnGdjcMJtFazMBkxttW/uO0Qpl3136dfGymR7IiKaw9VdBPZ1k9GZ5SPyEweRHUI3XVXXsMdOhjTv7HpZR7OWd80+QE= BN1PR03MB121: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB121;4:/BmgIgIGJcyzHrGmbplLsuOrn2Sy684OrxN2OlGkDrdyvs5pFQfruQiUljptLUBLSrQzitekKOdn9Gequ9wLhnxwLz66jh8OTXh9L7DDgew/FDORBwYzihHgOt+2Nr7wMhauB1LNsu2DZDf5+1DP5v1ZlTTPdJyN9/ReIBDI6Ls+md0Aq3Hsey8GVFXxbeb49iiBbWIhfWLo1AMpwIqO5mi08n/zP1QlAzcLFpTa9Hj4LoE3axFZ8P/gPivKMN93Yo02CYroKtLF3zOm173oK1bnmKtur89ABtVfP5TAClc= X-Forefront-PRVS: 0644578634 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR03MB121;23:PbZDa8OG2kIOfMfJIosYHqeRb/hpOckGdze8Q0UDVH?= =?us-ascii?Q?jPCPGJ7YYpv+NY6khkUBHzxj4T0qua/Er+tvoht8erBoXQNNQDc/OKl4esFH?= =?us-ascii?Q?RvFAcU6TCar1iYCKKnKRIQ64WnjCd6uJXQugOi6DKUr5Zd2fnFYwqeBSrx0H?= =?us-ascii?Q?ju61XuwSMGzXiSt3gx6CK7alLSUc7jGLamDKEfPDjqNPV27F7EEXkRWTRoxU?= =?us-ascii?Q?u6SOm7XLfE1Gvq1O+IBmqK0kdMIwhrndYJUwhBVSJgJ2qMSKvlVr5W58ovtD?= =?us-ascii?Q?xiX0e6RwYIyqs0Mm02RBrhiI3/4QpIlJf9WxAnrhAmNBYXUL6BFXqDxNoaow?= =?us-ascii?Q?RP7I8qglXMae709k0YLUDgLmqyM9cVCPbkN+pJ1ces03IIYI3fw30I0Cpuo6?= =?us-ascii?Q?GhwEXFZgMuyKfq4uCgPfCMcX2B0UCXB8xGl++Kaj4jqfT1ze7tCMoy7WYp4T?= =?us-ascii?Q?wen4sHAa0gx37YB7dULki3zNJf4PmaZoFWHjOUpYxNPfGVvlSZLxn6wtimY/?= =?us-ascii?Q?OBey4mfNvFHnGnprlpiugxvcHE7l8+Ij/iJB4x1SDYGjs3TBAgzzrm8SdOD6?= =?us-ascii?Q?91toInzXHmXzSD5Tg1JUKFnMKgHqgbYvkv3LqQHvK1qr/r64kvHLRYmPtgty?= =?us-ascii?Q?LBSJp8fbqfbg1mLhLQ0BbniQZJQYZdiS/5Pn6DK4LcR1dzou3RtthE+dFDph?= =?us-ascii?Q?g/zw86beLnFcGgmylPR9WBcn83/i9Yhum5gQYiYrCYZ5KybWHQ2KtN4lX5vH?= =?us-ascii?Q?PfruTfI/cGwVvR3mf/spkBf7e4Ngqy4ewBj5N/FxZWnxctQRtwLoSIPEz+mp?= =?us-ascii?Q?VS9mB7g8hPGuiI1sONswwdbVpO0hJE2fJ/LXXbxS+kIyoiZGYBrvZlhFz0dW?= =?us-ascii?Q?BJUtgDl1uL7Bdp3uHPWwHdmyWAdAuDcT1/h+NSwQY+b+IBy0elJtWwaJSn8M?= =?us-ascii?Q?7N1n9wYD+rMYrCyT7ElzKPhsf+OStWpXmO+xvk5l40R5OXX7Al9H8arDYvmx?= =?us-ascii?Q?7XDbrJgAO2luF6KTHGljtq78K4S1YS3yOSzcp4LH+UHQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB121;5:AccxkUdsckiBr8rhFAJdAUxF+y+NXO4/E4wLRyXC06EPIjyyAsTl+uxgmPT6C3gYleuiJAmFGDE/+DPkbg3rPRlD0g3PmgU5lPIdPIIMTuhRHToUPsHZB2T4Kp1w5UFIDc69p3/vG0HWiMgZZmyERA==;24:cPcXeeDiClBldNp90qj7HnNs9rT8Q8kJ/RIjSmwHBjDeOrm3bsvXd1UnC9T3sG6EfBYhF9NdhOVh+Dg8CA36E9QnlopSkWx9tBN5Z+vJxbY=;20:qfATh2zyqZf97cVOw/7uvNm1gFst7q+l1RCOQU439L5LU/s8aC5vUv9uMz7wbHmsgFsdKdLRJGwbTQZgWNvQBqeUtrUe9kIUhOUvpobA5uH29iDFaCmXbC1kYQiqG6Ck7iD4BLklQ0tpaHPcxVwYXMg7fg+ckaRZ8qOcPTgq/Eo= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2015 15:28:39.6303 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB121 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2272 Lines: 60 --8323329-1899992832-1437492168=:22725 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Tue, 21 Jul 2015, Tyler Baker wrote: > Hi, > > On 17 July 2015 at 17:53, Stephen Boyd wrote: > > On 07/06, dinguyen@opensource.altera.com wrote: > >> From: Dinh Nguyen > >> > >> Use of_clk_parent_fill to fill in the parent clock names' array. > >> > >> Signed-off-by: Dinh Nguyen > >> Cc: Maxime Ripard > >> Cc: "Emilio López" > >> --- > > > > Applied to clk-next with that fix I posted. > > The kernelci.org bot reported sunxi a20 boot failures[1][2] in > next-20150720 and next-20150721. I have bisected[3] these failures to > this commit. However, I have not investigated any further but > reverting this commit on top of next-20150721 gets the boards booting > again. > Can you please try this patch? -->8- diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index e8c5185..958655f 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -204,7 +204,7 @@ static void __init sun6i_ahb1_clk_setup(struct device_node *node) return; /* we have a mux, we will have >1 parents */ - of_clk_parent_fill(node, parents, SUN6I_AHB1_MAX_PARENTS); + i = of_clk_parent_fill(node, parents, SUN6I_AHB1_MAX_PARENTS); of_property_read_string(node, "clock-output-names", &clk_name); ahb1 = kzalloc(sizeof(struct sun6i_ahb1_clk), GFP_KERNEL); @@ -789,7 +789,7 @@ static void __init sunxi_mux_clk_setup(struct device_node *node, reg = of_iomap(node, 0); - of_clk_parent_fill(node, parents, SUNXI_MAX_PARENTS); + i = of_clk_parent_fill(node, parents, SUNXI_MAX_PARENTS); of_property_read_string(node, "clock-output-names", &clk_name); clk = clk_register_mux(NULL, clk_name, parents, i, --8323329-1899992832-1437492168=:22725-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/