Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755489AbbGUPXk (ORCPT ); Tue, 21 Jul 2015 11:23:40 -0400 Received: from www.linutronix.de ([62.245.132.108]:33837 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754062AbbGUPXi (ORCPT ); Tue, 21 Jul 2015 11:23:38 -0400 Date: Tue, 21 Jul 2015 17:23:16 +0200 (CEST) From: Thomas Gleixner To: Pan Xinhui cc: "linux-kernel@vger.kernel.org" , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, toshi.kani@hp.com, jgross@suse.com, mcgrof@suse.com, "mnipxh@163.com" , "yanmin_zhang@linux.intel.com" Subject: Re: [PATCH V2] x86/mm/pat: Do a small optimization and fix in reserve_memtype In-Reply-To: <55AE0233.3080102@intel.com> Message-ID: References: <55ADFC78.9070707@intel.com> <55AE0233.3080102@intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 17 On Tue, 21 Jul 2015, Pan Xinhui wrote: > So *ret_type might be set to found_type(match->type), > > The call train is deep, it took me long time to review them. > As actual_type != new->type is possible, we need save new->type to actual_type. Fair enough. But that wants to have a comment in the code as any casual reader will trip over this. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/