Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933164AbbGUPdO (ORCPT ); Tue, 21 Jul 2015 11:33:14 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:32773 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754783AbbGUPdM (ORCPT ); Tue, 21 Jul 2015 11:33:12 -0400 Date: Tue, 21 Jul 2015 11:33:08 -0400 From: Tejun Heo To: Baoquan He Cc: cl@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] percpu: clean up of schunk->map[] assignment in pcpu_setup_first_chunk Message-ID: <20150721153308.GI15934@mtj.duckdns.org> References: <1437404130-5188-1-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437404130-5188-1-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 20 On Mon, Jul 20, 2015 at 10:55:28PM +0800, Baoquan He wrote: > The original assignment is a little redundent. > > Signed-off-by: Baoquan He Heh, I'm not sure this is actually better. Anyways, applied to percpu/for-4.3. In general tho, I don't really think this level of micro cleanup patches are worthwhile. If something around it changes, sure, take the chance and clean it up but as standalone patches these aren't that readily justifiable. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/