Date: Tue, 21 Jul 2015 14:37:26 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 02/47] perf stat: Introduce struct perf_stat_config
Message-ID: <20150721173726.GB16921@kernel.org>
References: <1437481927-29538-1-git-send-email-jolsa@kernel.org>
 <1437481927-29538-3-git-send-email-jolsa@kernel.org>
 <20150721172419.GH5368@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150721172419.GH5368@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 976
Lines: 20

Em Tue, Jul 21, 2015 at 02:24:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Jul 21, 2015 at 02:31:22PM +0200, Jiri Olsa escreveu:
> > Moving aggr_mode into new struct. The point is to centralize
> > the base stat config so it could be used localy together with
> > other stat routines in other parts of perf code.
> 
> Why not use 'struct perf_stat' for that? It is already there and is
> supposed to hold the stat tool internal state. Yeah, lots of those
> globals should go there as well, just like we have the 'perf_sched',
> 'perf_top', 'perf_script',y etc structs.

Erm, saw some more patches, this stuff gets marshalled into perf.data,
continuing to read... Probably you made this somehow extensible...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/