Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933822AbbGUSQE (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jul 2015 14:16:04 -0400
Received: from mail.skyhub.de ([78.46.96.112]:57089 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932807AbbGUSQC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jul 2015 14:16:02 -0400
Date: Tue, 21 Jul 2015 20:15:53 +0200
From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Baron <jasonbaron0@gmail.com>,
        Mikulas Patocka <mpatocka@redhat.com>,
        Paul Mackerras <paulus@samba.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Vince Weaver <vince@deater.net>, "hillf.zj" <hillf.zj@alibaba-inc.com>,
        Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: Kernel broken on processors without performance counters
Message-ID: <20150721181553.GA3378@nazgul.tnic>
References: <20150708160750.GQ19282@twins.programming.kicks-ass.net>
 <CALCETrVqeG=3sKJv=pe9ZfaeRmx9uz+jNmXGmPu-7Hah4NvYDQ@mail.gmail.com>
 <559D8250.8000707@gmail.com>
 <CALCETrUb8tjDLQHF3q=_F7JRXhC8iEHW9o2xFsUbqsmyEOAiCQ@mail.gmail.com>
 <20150710141359.GJ19282@twins.programming.kicks-ass.net>
 <20150721082107.GE18673@twins.programming.kicks-ass.net>
 <alpine.DEB.2.11.1507211726040.18576@nanos>
 <20150721154959.GS19282@twins.programming.kicks-ass.net>
 <CALCETrWwy777nYTVpOn8Hs1JRG5nDyvky9B11otDRAid1L19vg@mail.gmail.com>
 <20150721161215.GU19282@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150721161215.GU19282@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1736
Lines: 69

On Tue, Jul 21, 2015 at 06:12:15PM +0200, Peter Zijlstra wrote:
> Yes, if you start out false, you must be unlikely. If you start out
> true, you must be likely.
> 
> We could maybe try and untangle that if there really is a good use case,
> but this is the current state.
> 
> The whole reason this happened is because 'false' is like:
> 
> 
> 	...
> 	<nop>
> 1:
> 	...
> 
> 
> 
> label:
> 	<unlikely code>
> 	jmp 1b
> 
> 
> Where the code if out-of-line by default. The enable will rewrite the
> <nop> with a jmp label.

Btw, native_sched_clock() is kinda botched because of that, see below.

I'd want that RDTSC to come first with a NOP preceding it which can
become a JMP in case some idiotic CPU can't do RDTSC and needs to use
jiffies. Instead, we *unconditionally* jump to RDTSC which is WTF?! We
can just as well do a normal unlikely() without the static_key:

	.globl	native_sched_clock
	.type	native_sched_clock, @function
native_sched_clock:
	pushq	%rbp	#
	movq	%rsp, %rbp	#,
#APP
# 21 "./arch/x86/include/asm/jump_label.h" 1
	1:.byte 0x0f,0x1f,0x44,0x00,0
	.pushsection __jump_table,  "aw" 
	 .balign 8 
	 .quad 1b, .L122, __use_tsc 	#,
	.popsection 
	
# 0 "" 2
#NO_APP
	movabsq	$-4294667296000000, %rax	#, tmp118
	popq	%rbp	#
	imulq	$1000000, jiffies_64(%rip), %rdx	#, jiffies_64, D.28443
	addq	%rdx, %rax	# D.28443, D.28443
	ret
.L122:
#APP
# 118 "./arch/x86/include/asm/msr.h" 1
	rdtsc
# 0 "" 2

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/