Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933526AbbGUS37 (ORCPT ); Tue, 21 Jul 2015 14:29:59 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:33368 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932970AbbGUS35 (ORCPT ); Tue, 21 Jul 2015 14:29:57 -0400 MIME-Version: 1.0 In-Reply-To: <1437500193-10255-1-git-send-email-chris.j.arges@canonical.com> References: <20150721162418.GM38815@linux.vnet.ibm.com> <1437500193-10255-1-git-send-email-chris.j.arges@canonical.com> Date: Tue, 21 Jul 2015 11:29:56 -0700 Message-ID: Subject: Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes From: Pravin Shelar To: Chris J Arges Cc: nacc@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, linux-numa@vger.kernel.org, David Miller , netdev , "dev@openvswitch.org" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 25 On Tue, Jul 21, 2015 at 10:36 AM, Chris J Arges wrote: > Some architectures like POWER can have a NUMA node_possible_map that > contains sparse entries. This causes memory corruption with openvswitch > since it allocates flow_cache with a multiple of num_possible_nodes() and > assumes the node variable returned by for_each_node will index into > flow->stats[node]. > > Use nr_node_ids to allocate a maximal sparse array instead of > num_possible_nodes(). > > The crash was noticed after 3af229f2 was applied as it changed the > node_possible_map to match node_online_map on boot. > Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861 > > Signed-off-by: Chris J Arges Acked-by: Pravin B Shelar Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/