Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754624AbbGUUSP (ORCPT ); Tue, 21 Jul 2015 16:18:15 -0400 Received: from 36.223.133.77.rev.sfr.net ([77.133.223.36]:52919 "EHLO smtp.natisbad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbbGUUSM (ORCPT ); Tue, 21 Jul 2015 16:18:12 -0400 From: arno@natisbad.org (Arnaud Ebalard) To: Florian Fainelli , stsp@users.sourceforge.net Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, mxs@sbrk.org, devicetree@vger.kernel.org, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested References: <1437439798-12622-1-git-send-email-f.fainelli@gmail.com> X-PGP-Key-URL: http://natisbad.org/arno@natisbad.org.asc X-Fingerprint: D3A5 B68A 839B 38A5 815A 781B B77C 0748 A7AE 341B X-Hashcash: 1:20:150721:thomas.petazzoni@free-electrons.com::a9Wv/6Db3weDeNJd:000000000000000000000000000HYR X-Hashcash: 1:20:150721:stsp@users.sourceforge.net::IXhhMQXVd4SXR34m:000000000000000000000000000000000000EFG X-Hashcash: 1:20:150721:f.fainelli@gmail.com::zNrWm/Ni2cagefW8:000000000000000000000000000000000000000000fdl X-Hashcash: 1:20:150721:mxs@sbrk.org::92NbHCW7Pn97zlV9:000001toi X-Hashcash: 1:20:150721:davem@davemloft.net::XONSGU7jL/KAvtvv:0000000000000000000000000000000000000000001A57 X-Hashcash: 1:20:150721:devicetree@vger.kernel.org::erP9oHbJXiirJ4Sz:000000000000000000000000000000000001l7I X-Hashcash: 1:20:150721:linux-kernel@vger.kernel.org::2DY/bQhk4ScGAAmZ:0000000000000000000000000000000002Wql X-Hashcash: 1:20:150721:netdev@vger.kernel.org::ZbKKvjo02B+IIz9J:0000000000000000000000000000000000000005KPv Date: Tue, 21 Jul 2015 22:18:00 +0200 Message-ID: <87vbddmfif.fsf@natisbad.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 40 Hi guys, Florian Fainelli writes: > Changes in v5: > > - removed an invalid use of the link_update callback in the SF2 driver > was appeared after merging "net: phy: fixed_phy: handle link-down case" > > - reworded the commit message for patch 2 to make it clear what it fixes and > why this is required > > Initial cover letter from Stas: > > Hello. > > Currently the link status auto-negotiation is enabled > for any SGMII link with fixed-link DT binding. > The regression was reported: > https://lkml.org/lkml/2015/7/8/865 > Apparently not all HW that implements SGMII protocol, generates the > inband status for the auto-negotiation to work. > More details here: > https://lkml.org/lkml/2015/7/10/206 > > The following patches reverts to the old behavior by default, > which is to not enable the auto-negotiation for fixed-link. > The new DT property is added that allows to explicitly request > the auto-negotiation. FWIW, I tested this v5 series on mirabox (2 mvneta interfaces using RGMII); both interfaces still work as expected, i.e. no regression on my side. a+ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/