Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbbGUUfQ (ORCPT ); Tue, 21 Jul 2015 16:35:16 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:35757 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932116AbbGUUfN (ORCPT ); Tue, 21 Jul 2015 16:35:13 -0400 From: Guenter Roeck To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com, Jesper Nilsson , Guenter Roeck , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH -next] serial: etraxfs-uart: Update gpiod API Date: Tue, 21 Jul 2015 13:34:52 -0700 Message-Id: <1437510892-30376-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1818 Lines: 41 Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") makes the flags argument to devm_gpiod_get_optional mandatory but does not update all users. This results in the following build error. drivers/tty/serial/etraxfs-uart.c:933:16: error: too few arguments to function ‘devm_gpiod_get_optional’ Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") Cc: Uwe Kleine-König Signed-off-by: Guenter Roeck --- drivers/tty/serial/etraxfs-uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/etraxfs-uart.c b/drivers/tty/serial/etraxfs-uart.c index a57301a6fe42..e35a19b214d5 100644 --- a/drivers/tty/serial/etraxfs-uart.c +++ b/drivers/tty/serial/etraxfs-uart.c @@ -930,10 +930,10 @@ static int etraxfs_uart_probe(struct platform_device *pdev) up->irq = irq_of_parse_and_map(np, 0); up->regi_ser = of_iomap(np, 0); - up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr"); - up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr"); - up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri"); - up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd"); + up->dtr_pin = devm_gpiod_get_optional(&pdev->dev, "dtr", GPIOD_ASIS); + up->dsr_pin = devm_gpiod_get_optional(&pdev->dev, "dsr", GPIOD_ASIS); + up->ri_pin = devm_gpiod_get_optional(&pdev->dev, "ri", GPIOD_ASIS); + up->cd_pin = devm_gpiod_get_optional(&pdev->dev, "cd", GPIOD_ASIS); up->port.dev = &pdev->dev; cris_serial_port_init(&up->port, dev_id); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/