Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476AbbGUVBY (ORCPT ); Tue, 21 Jul 2015 17:01:24 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51327 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754716AbbGUVBX (ORCPT ); Tue, 21 Jul 2015 17:01:23 -0400 Date: Tue, 21 Jul 2015 23:01:15 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com, Jesper Nilsson Subject: Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API Message-ID: <20150721210115.GJ9981@pengutronix.de> References: <1437510892-30376-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1437510892-30376-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 38 On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote: > Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") > makes the flags argument to devm_gpiod_get_optional mandatory but does not > update all users. This results in the following build error. > > drivers/tty/serial/etraxfs-uart.c:933:16: error: > too few arguments to function ‘devm_gpiod_get_optional’ > > Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") > Cc: Uwe Kleine-König > Signed-off-by: Guenter Roeck We discussed this driver while I worked on updating the gpiod API. I don't care much about this driver, but if you want to do something about the build failure, I'd prefer: diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 76e65b714471..3a6a7c235f09 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1066,6 +1066,7 @@ config SERIAL_VT8500_CONSOLE config SERIAL_ETRAXFS bool "ETRAX FS serial port support" depends on ETRAX_ARCH_V32 && OF + depends on BROKEN select SERIAL_CORE config SERIAL_ETRAXFS_CONSOLE Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/