Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755864AbbGUVCm (ORCPT ); Tue, 21 Jul 2015 17:02:42 -0400 Received: from phil.doycomm.com ([66.219.128.249]:42163 "EHLO phil.doycomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510AbbGUVCk (ORCPT ); Tue, 21 Jul 2015 17:02:40 -0400 Subject: Re: [PATCH 4.0 00/58] 4.0.9-stable review From: Donald Parsons To: Greg Kroah-Hartman Cc: linux-kernel , Andrew Morton In-Reply-To: <20150721181358.GA20131@kroah.com> References: <1437498807.5718.15.camel@falcon.homelinux.org> <20150721181358.GA20131@kroah.com> Content-Type: text/plain; charset="us-ascii" Date: Tue, 21 Jul 2015 17:02:31 -0400 Message-ID: <1437512551.5718.19.camel@falcon.homelinux.org> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1861 Lines: 61 On Tue, 2015-07-21 at 11:13 -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote: > > Greg, > > > > The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when > > a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon > > Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14) > > > > This mis-compile was fixed in 4.1-rc8. The diff was: > > > > diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c > > linux-4.1-rc8/arch/x86/kvm/mmu.c > > --- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400 > > +++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400 > > @@ -4215,13 +4215,13 @@ > > u64 entry, gentry, *spte; > > int npte; > > bool remote_flush, local_flush, zap_page; > > - union kvm_mmu_page_role mask = (union kvm_mmu_page_role) { > > - .cr0_wp = 1, > > - .cr4_pae = 1, > > - .nxe = 1, > > - .smep_andnot_wp = 1, > > - .smap_andnot_wp = 1, > > - }; > > + union kvm_mmu_page_role mask = { }; > > + > > + mask.cr0_wp = 1; > > + mask.cr4_pae = 1; > > + mask.nxe = 1; > > + mask.smep_andnot_wp = 1; > > + mask.smap_andnot_wp = 1; > > > > /* > > * If we don't have indirect shadow pages, it means no page is > > > > > > Please add to linux-4.0.9 so older compilers will work. > > What is the commit id in Linus's tree that resolves this? I do not know but I found this in Linus' linux-4.1-rc8 email announce: Andrew Morton (1): arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug which must be it. Added Andrew to cc as he hopefully knows the answer to your question. Thanks, Don Parsons -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/