Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933310AbbGUVKo (ORCPT ); Tue, 21 Jul 2015 17:10:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41116 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754802AbbGUVKm (ORCPT ); Tue, 21 Jul 2015 17:10:42 -0400 Date: Tue, 21 Jul 2015 14:10:41 -0700 From: Greg Kroah-Hartman To: Donald Parsons Cc: linux-kernel , Andrew Morton Subject: Re: [PATCH 4.0 00/58] 4.0.9-stable review Message-ID: <20150721211041.GA22064@kroah.com> References: <1437498807.5718.15.camel@falcon.homelinux.org> <20150721181358.GA20131@kroah.com> <1437512551.5718.19.camel@falcon.homelinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437512551.5718.19.camel@falcon.homelinux.org> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2251 Lines: 64 On Tue, Jul 21, 2015 at 05:02:31PM -0400, Donald Parsons wrote: > On Tue, 2015-07-21 at 11:13 -0700, Greg Kroah-Hartman wrote: > > On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote: > > > Greg, > > > > > > The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when > > > a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon > > > Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14) > > > > > > This mis-compile was fixed in 4.1-rc8. The diff was: > > > > > > diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c > > > linux-4.1-rc8/arch/x86/kvm/mmu.c > > > --- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400 > > > +++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400 > > > @@ -4215,13 +4215,13 @@ > > > u64 entry, gentry, *spte; > > > int npte; > > > bool remote_flush, local_flush, zap_page; > > > - union kvm_mmu_page_role mask = (union kvm_mmu_page_role) { > > > - .cr0_wp = 1, > > > - .cr4_pae = 1, > > > - .nxe = 1, > > > - .smep_andnot_wp = 1, > > > - .smap_andnot_wp = 1, > > > - }; > > > + union kvm_mmu_page_role mask = { }; > > > + > > > + mask.cr0_wp = 1; > > > + mask.cr4_pae = 1; > > > + mask.nxe = 1; > > > + mask.smep_andnot_wp = 1; > > > + mask.smap_andnot_wp = 1; > > > > > > /* > > > * If we don't have indirect shadow pages, it means no page is > > > > > > > > > Please add to linux-4.0.9 so older compilers will work. > > > > What is the commit id in Linus's tree that resolves this? > > I do not know but I found this in Linus' linux-4.1-rc8 email announce: > > Andrew Morton (1): > arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug > > which must be it. Added Andrew to cc as he hopefully knows the answer > to your question. You can dig through git to find it pretty easily... Anyway, given that the 4.0 release I'm doing at the moment is the last one, and it's end-of-life, this is a bit late and isn't going to matter much. People should be on 4.1 already. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/