Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932835AbbGUV0v (ORCPT ); Tue, 21 Jul 2015 17:26:51 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:33797 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbbGUV0t (ORCPT ); Tue, 21 Jul 2015 17:26:49 -0400 Date: Tue, 21 Jul 2015 16:26:44 -0500 From: Bjorn Helgaas To: Marc Zyngier Cc: Thomas Gleixner , Jiang Liu , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yijing Wang , Ma Jun , Lorenzo Pieralisi , Duc Dang Subject: Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain field Message-ID: <20150721212644.GB3691@google.com> References: <1436962613-17359-1-git-send-email-marc.zyngier@arm.com> <1436962613-17359-5-git-send-email-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436962613-17359-5-git-send-email-marc.zyngier@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 32 On Wed, Jul 15, 2015 at 01:16:38PM +0100, Marc Zyngier wrote: > In order to be able to populate the device msi_domain field, > add the necesary hooks to propagate the host bridge msi_domain > across secondary busses to devices. > > So far, nobody populates the initial msi_domain. > > Signed-off-by: Marc Zyngier > --- > drivers/pci/probe.c | 30 ++++++++++++++++++++++++++++++ > include/linux/pci.h | 1 + > 2 files changed, 31 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index cefd636..376f6fa 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -661,6 +661,20 @@ static void pci_set_bus_speed(struct pci_bus *bus) > } > } > > +void __weak pcibios_set_host_bridge_msi_domain(struct pci_bus *bus) > +{ > +} I don't think there's anything in this series that requires this to be a weak function, is there? This is the only definition I see. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/