Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933986AbbGUXO0 (ORCPT ); Tue, 21 Jul 2015 19:14:26 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:36715 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933239AbbGUXOX (ORCPT ); Tue, 21 Jul 2015 19:14:23 -0400 MIME-Version: 1.0 In-Reply-To: <20150714192015.GO7021@wotan.suse.de> References: <1431996325-8840-1-git-send-email-mcgrof@do-not-panic.com> <1431996325-8840-3-git-send-email-mcgrof@do-not-panic.com> <20150714192015.GO7021@wotan.suse.de> From: "Luis R. Rodriguez" Date: Tue, 21 Jul 2015 16:14:02 -0700 X-Google-Sender-Auth: qA07NDmTHlXUKnHe75SAn-RhA_0 Message-ID: Subject: Re: [RFC v3 2/2] firmware: add firmware signature checking support To: Kees Cook , David Howells Cc: "Luis R. Rodriguez" , Ming Lei , Seth Forshee , Rusty Russell , Linus Torvalds , LKML , Paul Bolle , linux-wireless , Greg KH , jlee@suse.com, Takashi Iwai , Casey Schaufler , Matthew Garrett , Andrew Morton , Kyle McMartin , David Woodhouse Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 18 On Tue, Jul 14, 2015 at 12:20 PM, Luis R. Rodriguez wrote: >> > + strcpy(signed_name, buf->fw_id); >> > + strncat(signed_name, sign_ext, strlen(sign_ext)); >> >> fw_id is potentially unbounded, so using strncat hear poses an >> overflow risk. Maybe better to use strlcpy? >> > > Thanks for the feedback, indeed. Ok I've made this change based on David's tree. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/