Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964818AbbGVABO (ORCPT ); Tue, 21 Jul 2015 20:01:14 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:16728 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934166AbbGVABM (ORCPT ); Tue, 21 Jul 2015 20:01:12 -0400 X-IronPort-AV: E=Sophos;i="5.15,519,1432623600"; d="scan'208";a="70529997" Subject: Re: [PATCH v3 1/4] PCI: iproc: enable arm64 support for iProc PCIe To: Bjorn Helgaas References: <1437021563-29139-1-git-send-email-rjui@broadcom.com> <1437021563-29139-2-git-send-email-rjui@broadcom.com> <20150721203018.GH21967@google.com> <55AEB094.1090601@broadcom.com> <20150721220259.GK21967@google.com> CC: Catalin Marinas , Will Deacon , Arnd Bergmann , Mark Rutland , Hauke Mehrtens , , , , From: Ray Jui Message-ID: <55AEDD3E.6060808@broadcom.com> Date: Tue, 21 Jul 2015 17:01:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150721220259.GK21967@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2002 Lines: 59 On 7/21/2015 3:02 PM, Bjorn Helgaas wrote: > On Tue, Jul 21, 2015 at 01:50:28PM -0700, Ray Jui wrote: >> >> >> On 7/21/2015 1:30 PM, Bjorn Helgaas wrote: >>> On Wed, Jul 15, 2015 at 09:39:20PM -0700, Ray Jui wrote: >>>> This patch enables arm64 support to the iProc PCIe driver >>> >>> This needs a little more explanation: ARM has a common struct pci_sys_data >>> but ARM64 does not, >> >> Correct, and according to Arnd, there's already work in process of >> removing the need for pci_sys_data on arm32. Before that is done, we >> need this in the driver for it to work on both arm32 and arm64. >> >> and ARM needs pci_fixup_irqs() but ARM64 does not (why >>> not?), >> >> under arch/arm64/kernel/pci.c: >> >> 41 /* >> 42 * Try to assign the IRQ number from DT when adding a new device >> 43 */ >> 44 int pcibios_add_device(struct pci_dev *dev) >> 45 { >> 46 dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); >> 47 >> 48 return 0; >> 49 } >> >> interrupt is automatically parsed and mapped when adding a new device >> for arm64. >> >> ARM uses the common pci_sys_data for the PCI sysdata while ARM64 >>> uses a driver-specific sysdata, etc. >> >> Correct. pci_sys_data for arm32 will eventually be removed, so all arm32 >> based PCie host should only need to carry driver specific sysdata. > > That all makes sense. I'm just looking for a condensed version of it in > the changelog because it takes some digging to figure it out, and in a > couple months even the implicit context of "somebody's working to combine > arm32 and arm64" will be gone. So we need a changelog that motivates this > patch as it is. > Okay I will re-submit a new patch with a commit message that explains the change in more details. Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/