Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934211AbbGVAIp (ORCPT ); Tue, 21 Jul 2015 20:08:45 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:32909 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933883AbbGVAIo (ORCPT ); Tue, 21 Jul 2015 20:08:44 -0400 Date: Tue, 21 Jul 2015 17:08:42 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mel Gorman cc: Linux-MM , Johannes Weiner , Rik van Riel , Vlastimil Babka , Pintu Kumar , Xishi Qiu , Gioh Kim , LKML , Mel Gorman Subject: Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing In-Reply-To: <1437379219-9160-4-git-send-email-mgorman@suse.com> Message-ID: References: <1437379219-9160-1-git-send-email-mgorman@suse.com> <1437379219-9160-4-git-send-email-mgorman@suse.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 21 On Mon, 20 Jul 2015, Mel Gorman wrote: > From: Mel Gorman > > File-backed pages that will be immediately dirtied are balanced between > zones but it's unnecessarily expensive. Move consider_zone_balanced into > the alloc_context instead of checking bitmaps multiple times. > > Signed-off-by: Mel Gorman Acked-by: David Rientjes consider_zone_dirty eliminates zones over their dirty limits and zone_dirty_ok() returns true if zones are under their dirty limits, so the naming of both are a little strange. You might consider changing them while you're here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/