Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755947AbbGVF3B (ORCPT ); Wed, 22 Jul 2015 01:29:01 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36817 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753558AbbGVF27 (ORCPT ); Wed, 22 Jul 2015 01:28:59 -0400 Date: Tue, 21 Jul 2015 22:28:58 -0700 (PDT) Message-Id: <20150721.222858.1855944921733592230.davem@davemloft.net> To: khlebnikov@yandex-team.ru Cc: netdev@vger.kernel.org, tj@kernel.org, cgroups@vger.kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU usage" From: David Miller In-Reply-To: <20150721164629.18385.14538.stgit@buzz> References: <20150721164629.18385.14538.stgit@buzz> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Jul 2015 22:28:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 24 From: Konstantin Khlebnikov Date: Tue, 21 Jul 2015 19:46:29 +0300 > @@ -23,7 +23,8 @@ static inline struct cgroup_cls_state *css_cls_state(struct cgroup_subsys_state > > struct cgroup_cls_state *task_cls_state(struct task_struct *p) > { > - return css_cls_state(task_css(p, net_cls_cgrp_id)); > + return css_cls_state(task_css_check(p, net_cls_cgrp_id, > + rcu_read_lock_bh_held())); You've made a serious mess of the indentation here. First of all, you've changed the correct plain "TAB" before the 'return' line into a TAB and two SPACE characters. Secondly, the second line needs to be precisely indented to the exact column following the openning parenthesis of the task_css_check() call on the previous line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/