Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756319AbbGVHwc (ORCPT ); Wed, 22 Jul 2015 03:52:32 -0400 Received: from foss.arm.com ([217.140.101.70]:34636 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756006AbbGVHwa (ORCPT ); Wed, 22 Jul 2015 03:52:30 -0400 Message-ID: <55AF4BBA.5030209@arm.com> Date: Wed, 22 Jul 2015 08:52:26 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Hanjun Guo , Thomas Gleixner , Jiang Liu , Jason Cooper CC: "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lorenzo Pieralisi , Tomasz Nowicki , "Rafael J. Wysocki" , "suravee.suthikulpanit@amd.com" Subject: Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node field References: <1437473280-11431-1-git-send-email-marc.zyngier@arm.com> <1437473280-11431-2-git-send-email-marc.zyngier@arm.com> <55AF47D7.8010304@linaro.org> In-Reply-To: <55AF47D7.8010304@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2797 Lines: 61 On 22/07/15 08:35, Hanjun Guo wrote: > On 07/21/2015 06:07 PM, Marc Zyngier wrote: >> The struct irq_domain contains a "struct device_node *" field >> (of_node) that is almost the only link between the irqdomain >> and the device tree infrastructure. >> >> In order to prepare for the removal of that field, convert all >> users outside of kernel/irq/irqdomain.c to use an accessor. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/mips/cavium-octeon/octeon-irq.c | 4 ++-- >> arch/powerpc/platforms/cell/axon_msi.c | 2 +- >> arch/powerpc/platforms/cell/spider-pic.c | 9 ++++++--- >> arch/powerpc/platforms/powernv/opal-irqchip.c | 2 +- >> arch/powerpc/sysdev/ehv_pic.c | 3 ++- >> arch/powerpc/sysdev/fsl_msi.c | 2 +- >> arch/powerpc/sysdev/i8259.c | 3 ++- >> arch/powerpc/sysdev/ipic.c | 3 ++- >> arch/powerpc/sysdev/mpic.c | 3 ++- >> arch/powerpc/sysdev/mpic_msi.c | 2 +- >> arch/powerpc/sysdev/qe_lib/qe_ic.c | 3 ++- >> drivers/gpio/gpio-sodaville.c | 2 +- >> drivers/irqchip/exynos-combiner.c | 2 +- >> drivers/irqchip/irq-atmel-aic-common.c | 2 +- >> drivers/irqchip/irq-crossbar.c | 4 ++-- >> drivers/irqchip/irq-gic-v2m.c | 2 +- >> drivers/irqchip/irq-gic-v3-its.c | 2 +- >> drivers/irqchip/irq-gic-v3.c | 2 +- >> drivers/irqchip/irq-gic.c | 2 +- >> drivers/irqchip/irq-hip04.c | 2 +- >> drivers/irqchip/irq-mtk-sysirq.c | 2 +- >> drivers/irqchip/irq-s3c24xx.c | 4 ++-- >> drivers/irqchip/irq-tegra.c | 4 ++-- >> drivers/irqchip/irq-vf610-mscm-ir.c | 5 +++-- >> drivers/spmi/spmi-pmic-arb.c | 2 +- >> include/linux/irqdomain.h | 5 +++++ >> 26 files changed, 46 insertions(+), 32 deletions(-) > > It seems to me that some other files missed, > in arch/powerpc/platforms/pasemi/msi.c: > > if (!mpic->irqhost->of_node || > !of_device_is_compatible(mpic->irqhost->of_node, > "pasemi,pwrficient-openpic")) > return -ENODEV; > > If you need more eyes to find all of them, please count me in :) Looks like my coccinelle foo is still lacking a bit... Oh well. Thanks for the help! M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/