Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933174AbbGVIY5 (ORCPT ); Wed, 22 Jul 2015 04:24:57 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:51013 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932481AbbGVIYw (ORCPT ); Wed, 22 Jul 2015 04:24:52 -0400 X-Listener-Flag: 11101 Message-ID: <1437553489.22203.6.camel@mtksdaap41> Subject: Re: [PATCH 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup From: Yingjoe Chen To: Daniel Kurtz CC: James Liao , Russell King , srv_heupstream , Arnd Bergmann , "open list:OPEN FIRMWARE AND..." , Catalin Marinas , Michael Turquette , Daniel Lezcano , Stephen Boyd , "linux-kernel@vger.kernel.org" , "Olof Johansson" , Rob Herring , , Sascha Hauer , Matthias Brugger , Thomas Gleixner , , "linux-arm-kernel@lists.infradead.org" Date: Wed, 22 Jul 2015 16:24:49 +0800 In-Reply-To: References: <1436779969-18610-1-git-send-email-yingjoe.chen@mediatek.com> <1436779969-18610-2-git-send-email-yingjoe.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2073 Lines: 60 On Tue, 2015-07-14 at 15:39 +0800, Daniel Kurtz wrote: > Hi Yingjoe, > > On Mon, Jul 13, 2015 at 5:32 PM, Yingjoe Chen wrote: > > Spurious mtk timer interrupt is noticed at boot and cause kernel > > crash. It seems if GPT is enabled, it will latch irq status even > > when its IRQ is disabled. When irq is enabled afterward, we see > > spurious interrupt. > > Change init flow to only enable GPT_CLK_SRC at mtk_timer_init. > > > > Signed-off-by: Yingjoe Chen > > --- > > drivers/clocksource/mtk_timer.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > > index 68ab423..237c20b 100644 > > --- a/drivers/clocksource/mtk_timer.c > > +++ b/drivers/clocksource/mtk_timer.c > > @@ -156,9 +156,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt) > > writel(0x3f, evt->gpt_base + GPT_IRQ_ACK_REG); > > } > > > > -static void > > -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > > +static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, > > + u8 option, bool enable) > > This function can be: __init > > Other than this tiny nit, and the small potential conflict in patch 4, > this whole series is: > > Reviewed-by: Daniel Kurtz > > (I do think it is a bit strange that the mediatek,mt6577-timer binding > does not use "clock-names", but that is independent of this patch > set). > Hi Daniel, Thanks for your review. I added __init as you suggested, and Pi-Cheng already sent an updated version of his patch to resolve the conflict[1]. Joe.C [1] http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001592.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/