Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933422AbbGVIjk (ORCPT ); Wed, 22 Jul 2015 04:39:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33659 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933227AbbGVIiz (ORCPT ); Wed, 22 Jul 2015 04:38:55 -0400 Date: Wed, 22 Jul 2015 10:38:50 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 02/47] perf stat: Introduce struct perf_stat_config Message-ID: <20150722083850.GA19714@krava.brq.redhat.com> References: <1437481927-29538-1-git-send-email-jolsa@kernel.org> <1437481927-29538-3-git-send-email-jolsa@kernel.org> <20150721172419.GH5368@kernel.org> <20150721173726.GB16921@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150721173726.GB16921@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 34 On Tue, Jul 21, 2015 at 02:37:26PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 21, 2015 at 02:24:19PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Jul 21, 2015 at 02:31:22PM +0200, Jiri Olsa escreveu: > > > Moving aggr_mode into new struct. The point is to centralize > > > the base stat config so it could be used localy together with > > > other stat routines in other parts of perf code. > > > > Why not use 'struct perf_stat' for that? It is already there and is > > supposed to hold the stat tool internal state. Yeah, lots of those > > globals should go there as well, just like we have the 'perf_sched', > > 'perf_top', 'perf_script',y etc structs. hm, but it's used as perf_evsel priv data.. the 'struct perf_stat_config' is coupled with the same event, we could switch the name for: 'struct perf_stat' -> 'struct perf_evsel_stat' 'struct perf_stat_cmd' -> 'struct perf_stat' and move 'struct perf_stat_record' under 'struct perf_stat' ;-) > > Erm, saw some more patches, this stuff gets marshalled into perf.data, > continuing to read... Probably you made this somehow extensible... yep, I'm storing it in 'tag-value' way, it's mentioned in the changelog jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/