From: Noam Camus <noamc@ezchip.com>
To: <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>
CC: <Alexey.Brodkin@synopsys.com>, <vgupta@synopsys.com>,
        <gregkh@linuxfoundation.org>, <jslaby@suse.com>,
        Noam Camus <noamc@ezchip.com>
Subject: [PATCH 3/4] serial: 8250_dw: Add UPF_FIXED_TYPE to flags
Date: Wed, 22 Jul 2015 12:34:58 +0300
Message-ID: <1437557699-25722-4-git-send-email-noamc@ezchip.com>
In-Reply-To: <1437557699-25722-3-git-send-email-noamc@ezchip.com>
References: <1437557699-25722-1-git-send-email-noamc@ezchip.com>
 <1437557699-25722-2-git-send-email-noamc@ezchip.com>
 <1437557699-25722-3-git-send-email-noamc@ezchip.com>
MIME-Version: 1.0
Content-Type: text/plain
DB5PR02MB1142: X-MS-Exchange-Organization-RulesExecuted
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2015 09:35:55.5525
 (UTC)
X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;Ip=[212.179.42.66];Helo=[ezex10.ezchip.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1142
X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB0694;2:V78v9aU/ZuAioG8KwQ5kR3oe0zWK+CKAxPy6/Xcbhka67/uqhxOAi50QQEmJ7JS8;3:x2MI9Xyn6LZrO38+14sYVc9MoY+wR/PxEP7rD9iVnIoSx1SJXHikCfGAkPDBQ43tswNoanZR9ZXdugTp9Clr4jIKJW5GZogmdOgs5VGqVGWcw/6eDIliLKBAfLmTim/QdOJ56atPw1oz5Ahy54milfF/+1mPpJ0To+3oqMkTQiR1RdHleVI9kB0miB0MinAEsN/hgbtPkL4vJel6AWIYp2Aa5tM924i4/TR1GdWygP8=;25:JsNfBYTwgMFKqpjDXreJpeGOf2OlxMuS55eLOFTuumPpewoNTcwNfSRCrNohgN30oaU6f17kryVGSViFli9EuUjgUsoxgLR06V+Otz1AQkd9p+Po3re8m2IIknxA8+5Ks9D/dRU+TRZbj49nWTEt1j41uRyoofFBLz2IAh6aixYeP2vY50dkdyArFQxFp4JcPYXcT8joNZgyFLQtYbGFOUignwWPNGaAZpdDYY61JcgeGV/a6Hr5vEjqjzcGpUGG+ghP3oU44bDVV7mW8CfuQw==;20:ucRihO9PeNBEg0NIKTZtC8MaCNc9k8Ce+6Va8D01L01V/tG1SkMBIDyOD42ag3EWH+FB0heoV7n4+yO0yYIRjQ==;23:awLLat5+9T4RQhb7NJ1eSLBbkYz6ppK1aWS5m7iGbd4NI9L8oSf5ny3o4ozzlOU2Z24PegIb0j8cCqu7Aa6/7WEfzBqZT6L4g2ex3w9qO7NpPle+m86Z6bd7SCv9/MunABJ9CcwrTKQRVN72pgGgvOITXpnFjTRnyP0r6zkJnDDZcgCCYi80sM6LMJDzv2eP8Xh+rdxTWWrXi4/MdOEYeLooeVfV5eih0ZU6dVRs2o/yBVtkU99E1JCFpLKIZzLx
DB5PR02MB0694: X-MS-Exchange-Organization-RulesExecuted
X-OriginatorOrg: ezchip.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1391
Lines: 40

From: Noam Camus <noamc@ezchip.com>

Always add UPF_FIXED_TYPE to flags so autoconf() will be skipped.
We do that since autoconf() performs many writes to LCR that cause
BUSY interrupt.
The problem with such interrupt is that driver is not yet called to
request_irq() and generic IRQ subsystem will mask the UART line.

Signed-off-by: Noam Camus <noamc@ezchip.com>
---
 drivers/tty/serial/8250/8250_dw.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 1a57105..620f983 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -362,6 +362,14 @@ static int dw8250_probe_of(struct uart_port *p,
 	if (has_ucv)
 		dw8250_setup_port(up);
 
+	/* Writing to LCR may cause BUSY interrupt before we
+	 * register the IRQ line.
+	 * Currently autoconf() uses several writes to LCR.
+	 * In order to avoid calling to autoconf() always add
+	 * following flag.
+	 */
+	p->flags |= UPF_FIXED_TYPE;
+
 	/* if we have a valid fifosize, try hooking up DMA here */
 	if (p->fifosize) {
 		up->dma = &data->dma;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/