Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933821AbbGVJgf (ORCPT ); Wed, 22 Jul 2015 05:36:35 -0400 Received: from mail-am1on0055.outbound.protection.outlook.com ([157.56.112.55]:43733 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933767AbbGVJg3 (ORCPT ); Wed, 22 Jul 2015 05:36:29 -0400 Authentication-Results: spf=fail (sender IP is 212.179.42.66) smtp.mailfrom=ezchip.com; synopsys.com; dkim=none (message not signed) header.d=none; From: Noam Camus To: , CC: , , , , Noam Camus Subject: [PATCH 4/4] serial: 8250_dw: use serial_in() and not readl() Date: Wed, 22 Jul 2015 12:34:59 +0300 Message-ID: <1437557699-25722-5-git-send-email-noamc@ezchip.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1437557699-25722-4-git-send-email-noamc@ezchip.com> References: <1437557699-25722-1-git-send-email-noamc@ezchip.com> <1437557699-25722-2-git-send-email-noamc@ezchip.com> <1437557699-25722-3-git-send-email-noamc@ezchip.com> <1437557699-25722-4-git-send-email-noamc@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-21696.003 X-TM-AS-Result: No--7.670700-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD028;1:e/7bvgbFh+nPNXuXn2pa1q/1Ln+d/ZNCtqsXblSSndUe/VEaQJL9eYDVrLq/SF3t3jfii19Ee7+SvYn2y1tBI5k8BtwzMB+8vhhAvsUyomtV2mTsWqy122ByqIfniWaRBlAZgTEUu+FeJWlShn96IUlks1aDKS8T1dwv5MwaoqZmgHBOKLqkHONzVNmZltbL5NMoUijQM74OQKmMV76zz9m8TruWxXHCKSk+j/1Snpk16jhWije9t5npV8gEBtk95EGjPUWV0PD63YUXRtrYPDnUQpYiRRzOB8KBDQZWmhFwVYQJR4g+2Wi0PBzKW9M9efsrn7RxySgpBqTbLxK53X7Cz2SkA2S61equQlz9kShcBEZfwzgJ40Ls7tNkHyWFqFFdsGdYTko4Cpbpzd6Qcpu7XQt0scv3bPaWdpHLwoY= X-Forefront-Antispam-Report: CIP:212.179.42.66;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(339900001)(189002)(199003)(5001970100001)(189998001)(19580395003)(49486002)(5001920100001)(106466001)(46102003)(76176999)(229853001)(62966003)(93886004)(50226001)(92566002)(77096005)(6806004)(50986999)(48376002)(36756003)(47776003)(86362001)(5001770100001)(105606002)(50466002)(5003940100001)(33646002)(19580405001)(85426001)(77156002)(104016003)(107886002)(2950100001)(87936001)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR02MB1141;H:ezex10.ezchip.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB1141;2:7io4buvDT7Cfytat9CWWOwpN9PRzJ53IEoadUl5y1xwvmjer2iK3X+oSZ60Gd6/H;3:+/q9K6qjXnMBaN4H/lD0DOgRDgUUd1tsfw7zPumn/a1+dGtAHHuC3DxVy/NVLiktKha2tTUCfootVHHqS9oRlxLaqdFPsyzkjxFhBkvUzMk1/AGBP3i/uQ++Ij5lWqIQbFuzGMuTEc2n4+kghbhJTbD2UfsKyoX29QQocxLXlGboPRainaAaDQThSIn1FI5fUWNRaDkvRIO6QRoyhaAefmUd7t/gaRf6DYbZ7LrRMMU=;25:EwZS1wum/0L4ryvsdAWPdNZFoQ/NWzuHrwvptbH8N8eJWIflOnDwboed/WFcFakIJee13st7KgzsUVOgd2kdYez0vVJjrYYwjAm5bzwbTC2ZJHm269g3NXnRyu3fl0wg2QYMgKDfGxb3yf82XnpQbQ8/pEYQHfNgRQSJRCmSHwkRYrX7o5BVdZhouAVp+LK2tahL61RxGqVBk8RWIwxXNGUv9YvdlwNJKuhCew1G+Eosq238BDNHo0P+k9N/wbK4sR7XShamseivEwSYZyCTOQ==;20:VCAqI0g/hHLAuuVcHcSajhDSGDAqY5HG345m6BtYmqcd9nWMwO4lp0ZBHyaEBgSbVHOtLGvZQ7mpMqu6owLtCfcN7d0VkE/il01RHndCZsFbof1xY//34F27vvHBfGt+SoNEh7uPizHVL10dGnpeLyr3I/NC8JFSoEy6/vt5ifk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1141; DB5PR02MB1141: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB5PR02MB1141;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1141; X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB1141;4:gG/4epl5nouwhrbQkzfdhuan89wP3hQOCNJRn4NlcoRWw8NmER/bjhoF/qdw0FyUqp3EWVa2kH9Ek/7wYOefR6Yhaa20GuGzrGoGBtcmMgBNhfOd10e/RXhP3ayelO/WU/cpGxXUL9IHaWVB56ykAXqxhcfXBMpNO7767dyuyKaQsLqkCLF3QRW/704cXVPbDhiznLNcsD7mIAmWEvOjODypakzPdakU8hdMbDFPstV1efrXOUbPzwUs3Qw/DzzoCCw5uRk8K0i9Ft+CMC1kj6JPWGdfyXy+Yn34vYhBOqw= X-Forefront-PRVS: 0645BEB7AA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB5PR02MB1141;23:890ooE5H3Tiu2GrtbR9MiLyG8pJP4tey9h4eiQGiy?= =?us-ascii?Q?O0ZBOrsJQWA8wzKNHNeLxOBFtVk7KwzVRQ4ub+91va2PD1g2NXVggAl0je22?= =?us-ascii?Q?N0MRX8GMW1AnaAFl/aiXQ7RLpxfBBSmngAvz66ZIei+1jiT28gtoGnFI8sen?= =?us-ascii?Q?UvC3ZCE6bZM3dREkNXIGQco28QIEWVuur+L794km4/mDfk2Li0jOjNCc9c/m?= =?us-ascii?Q?kR0/fU0nFRdXZcgVRghVUJiJ2L1lvntegK4+rIC0UoKpRAaDV/oeNAUpzav6?= =?us-ascii?Q?BNC3XTtFlKyG6XpdrGyRzIuRAeaXVsa8g8bDxLHFX8dVDBuO2EWClshcEmXL?= =?us-ascii?Q?gTCUhl2eEH4761XkfIpbx09U0dR6pb/dnzqg2oTAQZwyPOOwlnCiQGdKShGQ?= =?us-ascii?Q?cw/BQfND+6i12NcOK/hN42Zb6bFunwjVWzkj5lSaFTz0THm/+TAQYFgJ1qxk?= =?us-ascii?Q?luqxmxLkFDeZcov7lZfeuyngl9v3Ga56TXLAnkZ/A8+I6//YaFmWgmUFqMII?= =?us-ascii?Q?C+iM6rsfVoX+s2mY0Zk9Il46AGW5U4BXorhKYdrWVgU8N6/ZxzqrE+BA+jgz?= =?us-ascii?Q?X1/KqzrBSA+ngZjnDYw4bX6O+bjy1AloGHpQlQus6VErQ2UaP4XkVrRm7q0w?= =?us-ascii?Q?0Os5mlZ8VtD7ag0IUr720SyaiEZGawSHfQKdKnwoRxiw5gj72hRJdSe/5b5u?= =?us-ascii?Q?YEjS4RXsXdV5g0BRtYkw3pArBqgB5Qslb2dJJbb46Cu79OV7jE38QlnkrdQS?= =?us-ascii?Q?InqLNdXM1ZvsjAk81z9xaOQq3wAHiJU81hTTNekfiBRaLaM9UoCTj65lQX2V?= =?us-ascii?Q?+L+TOfeFntOJmgWMlY20Q7f8c2J3OAaQdv4V4xol5jkixELrQbkPTX2agVpR?= =?us-ascii?Q?x3KITkEPgBYo5OpBPDXBpmBulFqbHBNkKj12YP+0RtvJwKKY+gL++lifLhlV?= =?us-ascii?Q?VBotOQE7LjvgYMrFeVkN1crDNlRt5KhzhsIQ8/0KwuNvfLRLX6PCW55OSC/U?= =?us-ascii?Q?Ue/Z7X6/O0a3cLiPXBB36faJAQ3P7DLKHHg4ZqIyNro8A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR02MB1141;5:4JRzGlgq+WULKc8tALQwSjHkmd+S/6sWt8f8Y1/iaqnJfwEq/YCn88agDcOlKCaMP3w5An8be4JSXe9nGTxz0+A1e1AHIKAH8LIHxWGbh9RskPDABh0jr7teELpsbcWJop9YCg+wGorpVVwPHY4nPQ==;24:UPPaaKMGRYgoH1pQVyfamcBf/VEyZ18u2Q9dac8uK8UtguKmAVvw9P56BPenZB0eu4KWnBPxKjLZtb3EH8rAJYoOBakawTbcuxMg58bnvrQ=;20:Y+CkJd1wnd9VgnHepcnQRcZTNYW0fRWJaZecPYx3lK6OGKuRfhOngnlkWRJgnko06o27a/z4Fi5vboalU+tjUQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2015 09:36:25.4373 (UTC) X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;Ip=[212.179.42.66];Helo=[ezex10.ezchip.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 43 From: Noam Camus This is now matches device endianness. Signed-off-by: Noam Camus --- drivers/tty/serial/8250/8250_dw.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 620f983..a64197c 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -291,7 +291,9 @@ static bool dw8250_dma_filter(struct dma_chan *chan, void *param) static void dw8250_setup_port(struct uart_8250_port *up) { struct uart_port *p = &up->port; - u32 reg = readl(p->membase + DW_UART_UCV); + u32 reg = (p->iotype == UPIO_MEM32BE) ? + ioread32be(p->membase + DW_UART_UCV) : + readl(p->membase + DW_UART_UCV); /* * If the Component Version Register returns zero, we know that @@ -303,7 +305,9 @@ static void dw8250_setup_port(struct uart_8250_port *up) dev_dbg_ratelimited(p->dev, "Designware UART version %c.%c%c\n", (reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff); - reg = readl(p->membase + DW_UART_CPR); + reg = (p->iotype == UPIO_MEM32BE) ? + ioread32be(p->membase + DW_UART_CPR) : + readl(p->membase + DW_UART_CPR); if (!reg) return; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/