Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934103AbbGVKgI (ORCPT ); Wed, 22 Jul 2015 06:36:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:17886 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933567AbbGVKgG (ORCPT ); Wed, 22 Jul 2015 06:36:06 -0400 Date: Wed, 22 Jul 2015 13:35:46 +0300 From: Dan Carpenter To: Dexuan Cui Cc: Vitaly Kuznetsov , "olaf@aepfle.de" , "pebolle@tiscali.nl" , "gregkh@linuxfoundation.org" , "jasowang@redhat.com" , "driverdev-devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "stephen@networkplumber.org" , "stefanha@redhat.com" , "netdev@vger.kernel.org" , "apw@canonical.com" , "davem@davemloft.net" Subject: Re: [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability Message-ID: <20150722103546.GO5371@mwanda> References: <1437476293-6837-1-git-send-email-decui@microsoft.com> <87zj2pk3jf.fsf@vitty.brq.redhat.com> <4538264677374d43961c2d709afb1dd3@SIXPR30MB031.064d.mgd.msft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4538264677374d43961c2d709afb1dd3@SIXPR30MB031.064d.mgd.msft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 32 On Wed, Jul 22, 2015 at 10:09:10AM +0000, Dexuan Cui wrote: > > I'd suggest you do something like > > > > if (ret == -EAGIAIN) > > return 0; > > else if (ret) > > return ret; > > > > to make it future-proof (e.g. when a new error is returned by > > hv_ringbuffer_peek). And a comment would also be useful as it is unclear > > why we silence errors here. > Hi Vitaly, > Thanks! > I think I made a mistake here: > the "if (ret != 0) return 0;" should be changed > to "if (ret != 0) return ret;" The double negative really doesn't not make the code more complicated. I like using a quadruple negative instead. if (ret != 0 != 0) return ret; regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/