Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934098AbbGVLLN (ORCPT ); Wed, 22 Jul 2015 07:11:13 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:37750 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933440AbbGVLLL (ORCPT ); Wed, 22 Jul 2015 07:11:11 -0400 Date: Wed, 22 Jul 2015 12:11:06 +0100 From: Matt Fleming To: "Jonathan (Zhixiong) Zhang" Cc: Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, ying.huang@intel.com, fu.wei@linaro.org, al.stone@linaro.org, bp@alien8.de, rjw@rjwysocki.net, catalin.marinas@arm.com, will.deacon@arm.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org Subject: Re: [PATCH V6 1/4] efi: x86: rearrange efi_mem_attributes() Message-ID: <20150722111106.GC2734@codeblueprint.co.uk> References: <1437438759-3686-1-git-send-email-zjzhang@codeaurora.org> <1437438759-3686-2-git-send-email-zjzhang@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437438759-3686-2-git-send-email-zjzhang@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 30 On Mon, 20 Jul, at 05:32:36PM, Jonathan (Zhixiong) Zhang wrote: > From: "Jonathan (Zhixiong) Zhang" > > x86 and ia64 implement efi_mem_attributes() differently. This > function needs to be available for other arch (such as arm64) > as well, such as for the purpose of ACPI/APEI. > > ia64 efi does not setup memmap variable and does not set > EFI_MEMMAP flag, so it needs to have its unique implementation > of efi_mem_attributes(). > > Move efi_mem_attributes() implementation from x86 to efi, and > declare it with __weak. It is recommended that other archs > should not override the default implementation. > > Signed-off-by: Jonathan (Zhixiong) Zhang > --- > arch/x86/platform/efi/efi.c | 18 ------------------ > drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 18 deletions(-) Reviewed-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/