Date: Wed, 22 Jul 2015 17:26:24 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: add error path
Message-ID: <20150722115624.GA12261@sudip-PC>
References: <1437564527-11667-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20150722113937.GN6166@nuc-i3427.alporthouse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150722113937.GN6166@nuc-i3427.alporthouse.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 972
Lines: 21

On Wed, Jul 22, 2015 at 12:39:37PM +0100, Chris Wilson wrote:
> On Wed, Jul 22, 2015 at 04:58:47PM +0530, Sudip Mukherjee wrote:
> > If any of the debug file creation fails we were just returning the
> > error code to the drm layer. But the debug files that we created in the
> > process were not removed. And debugfs files are not automatically
> > cleaned up.
> 
> Just handle the failure to add gracefully by only removing the ones we
> add during debugfs cleanup. One thing we do not actually want to do here
> is return an error - not setting up every file in debugfs shouldn't stop
> the driver from loading.
Ok, I will send the v2 day after tomorrow. Today and tomorrow I will
horribly busy in my dayjob.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/