Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964994AbbGVMHz (ORCPT ); Wed, 22 Jul 2015 08:07:55 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:33256 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964841AbbGVMHx (ORCPT ); Wed, 22 Jul 2015 08:07:53 -0400 MIME-Version: 1.0 In-Reply-To: <55AF822F.8060507@ti.com> References: <1436902186-6542-1-git-send-email-fcooper@ti.com> <55AEA008.6050808@ti.com> <55AF822F.8060507@ti.com> Date: Wed, 22 Jul 2015 14:07:52 +0200 Message-ID: Subject: Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators From: Ulf Hansson To: "Franklin S Cooper Jr." Cc: linux-omap , linux-mmc , "linux-kernel@vger.kernel.org" , Kishon , Roger Quadros , Lokesh Vutla , Murali Karicheri Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 41 [...] > Hi Ulf, > > Just to clarify do you have an issue with this patch or in general > you rather nothave !CONFIG_REGULATOR supported? If its the latter > then wouldit be better to remove the !CONFIG_REGULATOR portion from > this driver all together. I don't like this patch as is, as it seems like you are replacing the VMMC regulator that actually exist in HW by parsing a DT property. I think mmc_of_parse_voltage() shall *only* be used when the OCR mask (->ocr_avail) can't be fetched by using a regulator. Typically that's when the VMMC voltage levels are managed within the mmc controller itself. I don't have a strong opinion on how you solve that, but I guess you have two options. 1. Make sure the driver can be build and used both for CONFIG_REGULATOR and !CONFIG_REGULATOR. What you need to take care of then, is to assign the ->ocr_avail mask to a default value in the case when it can't be fetched from a regulator. Most mmc drivers has some kind of fall-back mechanism like this. For those SoC where you need/can control the VMMC regulator, make sure those enables CONFIG_REGULATOR to get the proper behaviour by omap_hsmmc. 2. Force omap_hsmmc to be build with CONFIG_REGULATOR. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/