Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964969AbbGVMUf (ORCPT ); Wed, 22 Jul 2015 08:20:35 -0400 Received: from mail-qg0-f41.google.com ([209.85.192.41]:34480 "EHLO mail-qg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934035AbbGVMUe (ORCPT ); Wed, 22 Jul 2015 08:20:34 -0400 Message-ID: <55AF8A8E.9070706@hurleysoftware.com> Date: Wed, 22 Jul 2015 08:20:30 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Noam Camus CC: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com, gregkh@linuxfoundation.org, jslaby@suse.com Subject: Re: [PATCH 2/4] serial: 8250_dw: Add UPF_SKIP_TEST to flags depend on device tree References: <1437557699-25722-1-git-send-email-noamc@ezchip.com> <1437557699-25722-2-git-send-email-noamc@ezchip.com> <1437557699-25722-3-git-send-email-noamc@ezchip.com> In-Reply-To: <1437557699-25722-3-git-send-email-noamc@ezchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1997 Lines: 54 Hi Noam, On 07/22/2015 05:34 AM, Noam Camus wrote: > From: Noam Camus > > Add support for OF option "no-loopback-test" Changes to devicetree need to at least get acks from DT maintainers. Regards, Peter Hurley > use case: simulator which does not implements loopback test mode. > > Signed-off-by: Noam Camus > --- > .../bindings/serial/snps-dw-apb-uart.txt | 2 ++ > drivers/tty/serial/8250/8250_dw.c | 3 +++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt > index 289c40e..5d16047 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.txt > @@ -33,6 +33,8 @@ Optional properties: > - ri-override : Override the RI modem status signal. This signal will always be > reported as inactive instead of being obtained from the modem status register. > Define this if your serial port does not use this pin. > +- no-loopback-test: set to indicate that the port does not implements loopback > + test mode > > Example: > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index fe0b487..1a57105 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -370,6 +370,9 @@ static int dw8250_probe_of(struct uart_port *p, > up->dma->txconf.dst_maxburst = p->fifosize / 4; > } > > + if (of_find_property(np, "no-loopback-test", NULL)) > + p->flags |= UPF_SKIP_TEST; > + > if (!of_property_read_u32(np, "reg-shift", &val)) > p->regshift = val; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/