Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932782AbbGVMv4 (ORCPT ); Wed, 22 Jul 2015 08:51:56 -0400 Received: from mail-qk0-f171.google.com ([209.85.220.171]:33094 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbbGVMvz (ORCPT ); Wed, 22 Jul 2015 08:51:55 -0400 Message-ID: <55AF91E8.3020903@hurleysoftware.com> Date: Wed, 22 Jul 2015 08:51:52 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Noam Camus CC: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com, gregkh@linuxfoundation.org, jslaby@suse.com Subject: Re: [PATCH 4/4] serial: 8250_dw: use serial_in() and not readl() References: <1437557699-25722-1-git-send-email-noamc@ezchip.com> <1437557699-25722-2-git-send-email-noamc@ezchip.com> <1437557699-25722-3-git-send-email-noamc@ezchip.com> <1437557699-25722-4-git-send-email-noamc@ezchip.com> <1437557699-25722-5-git-send-email-noamc@ezchip.com> In-Reply-To: <1437557699-25722-5-git-send-email-noamc@ezchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1710 Lines: 50 Hi Noam, On 07/22/2015 05:34 AM, Noam Camus wrote: > From: Noam Camus > > This is now matches device endianness. I'm not seeing where serial_in() is used here, as claimed by the $subject. Regards, Peter Hurley > Signed-off-by: Noam Camus > --- > drivers/tty/serial/8250/8250_dw.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index 620f983..a64197c 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -291,7 +291,9 @@ static bool dw8250_dma_filter(struct dma_chan *chan, void *param) > static void dw8250_setup_port(struct uart_8250_port *up) > { > struct uart_port *p = &up->port; > - u32 reg = readl(p->membase + DW_UART_UCV); > + u32 reg = (p->iotype == UPIO_MEM32BE) ? > + ioread32be(p->membase + DW_UART_UCV) : > + readl(p->membase + DW_UART_UCV); > > /* > * If the Component Version Register returns zero, we know that > @@ -303,7 +305,9 @@ static void dw8250_setup_port(struct uart_8250_port *up) > dev_dbg_ratelimited(p->dev, "Designware UART version %c.%c%c\n", > (reg >> 24) & 0xff, (reg >> 16) & 0xff, (reg >> 8) & 0xff); > > - reg = readl(p->membase + DW_UART_CPR); > + reg = (p->iotype == UPIO_MEM32BE) ? > + ioread32be(p->membase + DW_UART_CPR) : > + readl(p->membase + DW_UART_CPR); > if (!reg) > return; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/