Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756758AbbGVN5v (ORCPT ); Wed, 22 Jul 2015 09:57:51 -0400 Received: from resqmta-ch2-07v.sys.comcast.net ([69.252.207.39]:46087 "EHLO resqmta-ch2-07v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756159AbbGVN5u (ORCPT ); Wed, 22 Jul 2015 09:57:50 -0400 Date: Wed, 22 Jul 2015 08:57:45 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: "Paul E. McKenney" cc: Andy Lutomirski , Chris Metcalf , Gilad Ben Yossef , Steven Rostedt , Ingo Molnar , Peter Zijlstra , Andrew Morton , Rik van Riel , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , Viresh Kumar , "linux-doc@vger.kernel.org" , Linux API , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/5] nohz_full: add support for "cpu_isolated" mode In-Reply-To: <20150721203622.GX3717@linux.vnet.ibm.com> Message-ID: References: <1436817481-8732-1-git-send-email-cmetcalf@ezchip.com> <1436817481-8732-2-git-send-email-cmetcalf@ezchip.com> <55A4271B.9040506@ezchip.com> <55AE993E.6040501@ezchip.com> <20150721203622.GX3717@linux.vnet.ibm.com> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 24 On Tue, 21 Jul 2015, Paul E. McKenney wrote: > > > In the current version, there's also the vmstat_update() that > > > may schedule delayed work and interrupt the core again > > > shortly before realizing that there are no more counter updates > > > happening, at which point it quiesces. Currently we handle > > > this in cpu_isolated mode simply by spinning and waiting for > > > the timer interrupts to complete. > > > > Perhaps we should fix that? > > Didn't Christoph Lameter fix this? Or is this an additional problem? Well the vmstat update must realize first that there are no outstanding updates before switching itself off. So typically there is one extra tick. But we could add another function that will simply fold the differential immediately and turn the kworker task in the expectation that the processor will stay quiet. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/