Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965381AbbGVO1S (ORCPT ); Wed, 22 Jul 2015 10:27:18 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38766 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933285AbbGVO1R (ORCPT ); Wed, 22 Jul 2015 10:27:17 -0400 Date: Wed, 22 Jul 2015 16:27:13 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Sebastian Reichel Cc: Michael Welling , Pavel Machek , Tony Lindgren , Ivaylo Dimitrov , Aaro Koskinen , Nishanth Menon , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux 4.2-rc1 broken Nokia N900 Message-ID: <20150722142713.GE22138@pali> References: <201507140002.44119@pali> <20150713223607.GA23001@deathray> <20150714071412.GA12844@pali> <20150720204647.GA11931@deathstar> <20150721093441.GA23241@amd> <20150722001741.GA7950@deathstar> <20150722020306.GA8379@earth> <20150722051334.GA2165@deathstar> <20150722072732.GB22138@pali> <20150722133318.GA17442@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150722133318.GA17442@earth> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2276 Lines: 55 On Wednesday 22 July 2015 15:33:18 Sebastian Reichel wrote: > Hi, > > On Wed, Jul 22, 2015 at 09:27:32AM +0200, Pali Rohár wrote: > > > > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > > > > index 5867384..f7d9ffd 100644 > > > > --- a/drivers/spi/spi-omap2-mcspi.c > > > > +++ b/drivers/spi/spi-omap2-mcspi.c > > > > @@ -245,6 +245,7 @@ static void omap2_mcspi_set_enable(const struct spi_device *spi, int enable) > > > > > > > > static void omap2_mcspi_set_cs(struct spi_device *spi, bool enable) > > > > { > > > > + struct omap2_mcspi *mcspi = spi_master_get_devdata(spi->master); > > > > u32 l; > > > > > > > > /* The controller handles the inverted chip selects > > > > @@ -255,6 +256,8 @@ static void omap2_mcspi_set_cs(struct spi_device *spi, bool enable) > > > > enable = !enable; > > > > > > > > if (spi->controller_state) { > > > > + pm_runtime_get_sync(mcspi->dev); > > > > + > > > > > > Should the return code should be checked here as with the other > > > instances of pm_runtime_get_sync? > > Yes. If it fails, the line fetch error would be triggered again. > > Probably the set_cs callback should also be changed, so that it can > return an error code. This is not something for 4.2-rc, though. > > > Anyway, what do you think about adding gcc macro for pm_runtime_get_sync > > function which report compiler warning when return value is not checked? > > Adding __must_check to pm_runtime_get_sync() should be discussed > separately with the relevant people in Cc. A quick grep in drivers/ > reveals a huge amount of code not handling pm_runtime_get_sync's return > code. > > -- Sebastian Two times, missing check for pm_runtime_get_sync() cased kernel crash on Nokia N900. See that crypto commits. I think all drivers which do not check should be fixed. Otherwise we can see another mysterious problems. Sebastian, can you CC relevant people? Or maybe start new thread? -- Pali Rohár pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/