Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934355AbbGVOs2 (ORCPT ); Wed, 22 Jul 2015 10:48:28 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38403 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932921AbbGVOs1 (ORCPT ); Wed, 22 Jul 2015 10:48:27 -0400 MIME-Version: 1.0 In-Reply-To: <55AFABF3.5050303@arm.com> References: <1436962613-17359-1-git-send-email-marc.zyngier@arm.com> <1436962613-17359-5-git-send-email-marc.zyngier@arm.com> <20150721212644.GB3691@google.com> <55AFABF3.5050303@arm.com> From: Bjorn Helgaas Date: Wed, 22 Jul 2015 09:48:06 -0500 Message-ID: Subject: Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain field To: Marc Zyngier Cc: Thomas Gleixner , Jiang Liu , Jason Cooper , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yijing Wang , Ma Jun , Lorenzo Pieralisi , Duc Dang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1733 Lines: 46 On Wed, Jul 22, 2015 at 9:42 AM, Marc Zyngier wrote: > Hi Bjorn, > > On 21/07/15 22:26, Bjorn Helgaas wrote: >> On Wed, Jul 15, 2015 at 01:16:38PM +0100, Marc Zyngier wrote: >>> In order to be able to populate the device msi_domain field, >>> add the necesary hooks to propagate the host bridge msi_domain >>> across secondary busses to devices. >>> >>> So far, nobody populates the initial msi_domain. >>> >>> Signed-off-by: Marc Zyngier >>> --- >>> drivers/pci/probe.c | 30 ++++++++++++++++++++++++++++++ >>> include/linux/pci.h | 1 + >>> 2 files changed, 31 insertions(+) >>> >>> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >>> index cefd636..376f6fa 100644 >>> --- a/drivers/pci/probe.c >>> +++ b/drivers/pci/probe.c >>> @@ -661,6 +661,20 @@ static void pci_set_bus_speed(struct pci_bus *bus) >>> } >>> } >>> >>> +void __weak pcibios_set_host_bridge_msi_domain(struct pci_bus *bus) >>> +{ >>> +} >> >> I don't think there's anything in this series that requires this to be a >> weak function, is there? This is the only definition I see. > > It looks like all the pcibios_* functions so far have a weak attribute, > and I've added it as a matter of consistency. We've used pcibios_* names where we might need an arch-specific implementation. I'm not sure that's the case here -- do you envision an implementation under arch/* someday? If not, maybe it should just be a pci_* function instead of pcibios_*. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/