Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934485AbbGVOwJ (ORCPT ); Wed, 22 Jul 2015 10:52:09 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:45163 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbbGVOwG (ORCPT ); Wed, 22 Jul 2015 10:52:06 -0400 Message-ID: <55AFADF4.5030409@roeck-us.net> Date: Wed, 22 Jul 2015 07:51:32 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= CC: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com, Jesper Nilsson , kernel@pengutronix.de Subject: Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API References: <1437510892-30376-1-git-send-email-linux@roeck-us.net> <20150721210115.GJ9981@pengutronix.de> <55AEC50E.3030202@roeck-us.net> <20150722070659.GK9981@pengutronix.de> In-Reply-To: <20150722070659.GK9981@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1561 Lines: 40 On 07/22/2015 12:06 AM, Uwe Kleine-König wrote: > While I stumbled over the calls to gpiod_get variants in the etraxfs > serial driver I noticed several problems with that driver. I pointed > them out in > > http://www.spinics.net/lists/linux-serial/msg17794.html > > . If you read the follow-ups Jesper Nilsson then said: > > I can push a patch that just drops all signal handling (since > it's bogus ATM), or you can ignore the driver as currently > implemented. > If you want to mark the driver as BROKEN due to those other problems, go ahead, and I'll drop the architecture from my tests. But it should not be marked BROKEN because you did not update an API. > I explicitly did the latter. Apart from that single driver I fixed all > users. @Jesper: You said you poked Niklas to care for that. Any news > from that front? > > I'm all for the usual habit that API changes should be handled by the > API changer. But if the code was already relying on undefined behaviour > before the change and fixing that needs testing on the respective > hardware, I think pushing the needed work back to the driver owner is > fine. IMHO a simple build fix that doesn't fix the brokeness isn't that > helpful here. > The driver works fine for me (in qemu), possibly because qemu doesn't use/need modem lines. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/