Message-ID: <1437576912.3484.8.camel@gmail.com>
Subject: Re: [patch] workqueue: schedule WORK_CPU_UNBOUND work on
 wq_unbound_cpumask CPUs
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>,
        "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
Date: Wed, 22 Jul 2015 16:55:12 +0200
In-Reply-To: <20150722141148.GL15934@mtj.duckdns.org>
References: <9e53de7c91c885ee255e16ee25f401d9eedf08d9.1437067317.git.bristot@redhat.com>
	 <20150716192448.GY15934@mtj.duckdns.org>
	 <1437107190.3438.23.camel@gmail.com>
	 <20150717152720.GD15934@mtj.duckdns.org>
	 <1437153348.5860.32.camel@gmail.com> <20150718133602.GA3041@lerouge>
	 <1437292973.3505.83.camel@gmail.com> <1437468925.12755.57.camel@gmail.com>
	 <1437542686.3106.55.camel@gmail.com>
	 <20150722141148.GL15934@mtj.duckdns.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1216
Lines: 25

On Wed, 2015-07-22 at 10:11 -0400, Tejun Heo wrote:
> On Wed, Jul 22, 2015 at 07:24:46AM +0200, Mike Galbraith wrote:
> > WORK_CPU_UNBOUND work items queued to a bound workqueue always run
> > locally.  This is a good thing normally, but not when the user has
> 
> The constant name used there is a bit misleading but you can't put
> work items which are queued w/ queue_work() on foreign cpus by
> default.  queue_work() has always guaranteed local execution.  The
> problem is that workqueue can't currently tell whether a queue_work()
> user expects cpu locality for correctness or optimization.  It'd be
> great if we introduce queue_work_on_local() or sth and replace
> correctness ones with it but that involves auditing each and every
> queue_work() usage.  If anybody is up for the task, I'd be happy to
> help.

Oh well.  That puts a big dent in the utility of wq_unbound_cpumask, but
too bad.  If someone has a big enough HPC itch, they'll scratch it.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/