Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934518AbbGVPTG (ORCPT ); Wed, 22 Jul 2015 11:19:06 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:33741 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934322AbbGVPTD (ORCPT ); Wed, 22 Jul 2015 11:19:03 -0400 Message-ID: <1437578340.3484.15.camel@gmail.com> Subject: Re: [patch] workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs From: Mike Galbraith To: Tejun Heo Cc: Lai Jiangshan , Frederic Weisbecker , Daniel Bristot de Oliveira , LKML , Rik van Riel , "Luis Claudio R. Goncalves" Date: Wed, 22 Jul 2015 17:19:00 +0200 In-Reply-To: <1437576912.3484.8.camel@gmail.com> References: <9e53de7c91c885ee255e16ee25f401d9eedf08d9.1437067317.git.bristot@redhat.com> <20150716192448.GY15934@mtj.duckdns.org> <1437107190.3438.23.camel@gmail.com> <20150717152720.GD15934@mtj.duckdns.org> <1437153348.5860.32.camel@gmail.com> <20150718133602.GA3041@lerouge> <1437292973.3505.83.camel@gmail.com> <1437468925.12755.57.camel@gmail.com> <1437542686.3106.55.camel@gmail.com> <20150722141148.GL15934@mtj.duckdns.org> <1437576912.3484.8.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 29 On Wed, 2015-07-22 at 16:55 +0200, Mike Galbraith wrote: > On Wed, 2015-07-22 at 10:11 -0400, Tejun Heo wrote: > > On Wed, Jul 22, 2015 at 07:24:46AM +0200, Mike Galbraith wrote: > > > WORK_CPU_UNBOUND work items queued to a bound workqueue always run > > > locally. This is a good thing normally, but not when the user has > > > > The constant name used there is a bit misleading but you can't put > > work items which are queued w/ queue_work() on foreign cpus by > > default. queue_work() has always guaranteed local execution. The > > problem is that workqueue can't currently tell whether a queue_work() > > user expects cpu locality for correctness or optimization. It'd be > > great if we introduce queue_work_on_local() or sth and replace > > correctness ones with it but that involves auditing each and every > > queue_work() usage. If anybody is up for the task, I'd be happy to > > help. > > Oh well. That puts a big dent in the utility of wq_unbound_cpumask, but > too bad. If someone has a big enough HPC itch, they'll scratch it. Ew, looking at the numbers, they may prefer to either a) pretend to not notice, or b) scurry off to HPC'R'US store if a) won't fly ;-) -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/