Message-ID: <1437578613.3214.257.camel@hp.com>
Subject: Re: [PATCH] x86: adjust default caching mode translation tables
From: Toshi Kani <toshi.kani@hp.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: bp@alien.de, mingo@elte.hu, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, hpa@zytor.com
Date: Wed, 22 Jul 2015 09:23:33 -0600
In-Reply-To: <55AFD027020000780009424E@prv-mh.provo.novell.com>
References: <55ACC3660200007800092E62@mail.emea.novell.com>
	 <1437517740.3214.247.camel@hp.com>
	 <55AFD027020000780009424E@prv-mh.provo.novell.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1797
Lines: 43

On Wed, 2015-07-22 at 09:17 -0600, Jan Beulich wrote:
> > 
> > > > On 22.07.15 at 00:29, <toshi.kani@hp.com> wrote:
> > On Mon, 2015-07-20 at 08:46 +0100, Jan Beulich wrote:
> > > Make WT really mean WT (rather than UC).
> > > 
> > > I can't see why commit 9cd25aac1f ("x86/mm/pat: Emulate PAT when it 
> > > is
> > > disabled") didn't make this match its changes to pat_init().
> > 
> > No, the default values need to be set to the fallback types, i.e. 
> > minimal
> > supported mode.  For WC and WT, UC is the fallback type.
> 
> But why would that be?
> 
> > When PAT is disabled, pat_init() does update the tables below to enable 
> > WT 
> > per the default BIOS setup.  However, when PAT is enabled, but CPU has 
> > PAT
> > -errata, WT falls back to UC per the default values. 
> 
> PAT related errata I'm aware of are related to either page size or
> the number of bits used to index into the PAT MSR, but never to
> a particular memory type. Are you saying there are errata which
> make use of WT or WC impossible altogether? Otherwise I would
> have thought (even more so in the absence of any comment
> saying otherwise - "minimal supported modes" doesn't really say
> on what basis the set is the minimal one) that the mode systems
> come up in (compatible with pre-PAT) ought to be what the tables
> express.

Please take a look at the comments in pat_init().  WT uses slot 7 (not slot
1) in the regular case.  We need to use the PAT bit in order to support
both WC and WT.  The PAT errata causes the PAT bit ineffective.

Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/