Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965558AbbGVQtv (ORCPT ); Wed, 22 Jul 2015 12:49:51 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:33759 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965457AbbGVQtp (ORCPT ); Wed, 22 Jul 2015 12:49:45 -0400 From: Vince Weaver X-Google-Original-From: Vince Weaver Date: Wed, 22 Jul 2015 12:56:23 -0400 (EDT) To: Peter Zijlstra cc: Vince Weaver , linux-kernel@vger.kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo Subject: Re: perf: multiplexing broken on amd fam16h? In-Reply-To: <20150722154147.GI18673@twins.programming.kicks-ass.net> Message-ID: References: <20150721193224.GW19282@twins.programming.kicks-ass.net> <20150722122208.GB19282@twins.programming.kicks-ass.net> <20150722150624.GV25159@twins.programming.kicks-ass.net> <20150722154147.GI18673@twins.programming.kicks-ass.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1848 Lines: 59 On Wed, 22 Jul 2015, Peter Zijlstra wrote: > On Wed, Jul 22, 2015 at 05:06:24PM +0200, Peter Zijlstra wrote: > > On Wed, Jul 22, 2015 at 11:02:21AM -0400, Vince Weaver wrote: > > > On Wed, 22 Jul 2015, Vince Weaver wrote: > > > > > > > > OK, so I have to admit I'm a bit weak on ftrace. What type of command > > > > line are you interested in seeing? The ones I've tried with trace-cmd > > > > have activated your trace_printks but there's 500MB of other data mixed > > > > in so maybe I am doing something wrong. > > > > > > maybe the "nop" plugin was what I wanted. I've posted the trace with that > > > here: > > > > > > http://web.eece.maine.edu/~vweaver/junk/jaguar.mpx.out.gz > > > > OK, that looks about right, lemme to stare at that. > > Does this help? yes, with this applied the check_multiplex test passes. Vince > > --- > kernel/events/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index d3dae3419b99..10d076b2572c 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -1868,8 +1868,6 @@ event_sched_in(struct perf_event *event, > > perf_pmu_disable(event->pmu); > > - event->tstamp_running += tstamp - event->tstamp_stopped; > - > perf_set_shadow_time(event, ctx, tstamp); > > perf_log_itrace_start(event); > @@ -1881,6 +1879,8 @@ event_sched_in(struct perf_event *event, > goto out; > } > > + event->tstamp_running += tstamp - event->tstamp_stopped; > + > if (!is_software_event(event)) > cpuctx->active_oncpu++; > if (!ctx->nr_active++) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/