Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934889AbbGVRLZ (ORCPT ); Wed, 22 Jul 2015 13:11:25 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34800 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934867AbbGVRLV (ORCPT ); Wed, 22 Jul 2015 13:11:21 -0400 Date: Wed, 22 Jul 2015 19:11:19 +0200 From: Alexandre Belloni To: Vaibhav Jain Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Neelesh Gupta , Michael Neuling , Alessandro Zummo , rtc-linux@googlegroups.com Subject: Re: [PATCH] rtc/rtc-opal: Enable alarms only when opal supports tpo Message-ID: <20150722171119.GJ2853@piout.net> References: <1436860708-17058-1-git-send-email-vaibhav@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436860708-17058-1-git-send-email-vaibhav@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 32 On 14/07/2015 at 13:28:28 +0530, Vaibhav Jain wrote : > rtc-opal driver provides support for rtc alarms via > timed-power-on(tpo). However some Power platforms like BML use a fake > rtc clock and don't support tpo. Such platforms are indicated by the > missing 'has-tpo' property in the device tree. > > Current implementation however enables callback for > rtc_class_ops.read/set alarm irrespective of the tpo support from the > platform. This results in a failed opal call when kernel tries to read > an existing alarms via opal_get_tpo_time during rtc device registration. > > This patch fixes this issue by setting opal_rtc_ops.read/set_alarm > callback pointers only when tpo is supported. > > Acked-by: Michael Neuling > Acked-by: Neelesh Gupta > Signed-off-by: Vaibhav Jain > --- > drivers/rtc/rtc-opal.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/