Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757074AbbGVRVb (ORCPT ); Wed, 22 Jul 2015 13:21:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51837 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753382AbbGVRV3 (ORCPT ); Wed, 22 Jul 2015 13:21:29 -0400 Subject: Re: [PATCH V6 1/4] efi: x86: rearrange efi_mem_attributes() To: Matt Fleming References: <1437438759-3686-1-git-send-email-zjzhang@codeaurora.org> <1437438759-3686-2-git-send-email-zjzhang@codeaurora.org> <20150722111106.GC2734@codeblueprint.co.uk> Cc: Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, ying.huang@intel.com, fu.wei@linaro.org, al.stone@linaro.org, bp@alien8.de, rjw@rjwysocki.net, catalin.marinas@arm.com, will.deacon@arm.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org From: "Zhang, Jonathan Zhixiong" Message-ID: <55AFD117.90801@codeaurora.org> Date: Wed, 22 Jul 2015 10:21:27 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150722111106.GC2734@codeblueprint.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 36 Appreciate Matt for your ack. On 7/22/2015 4:11 AM, Matt Fleming wrote: > On Mon, 20 Jul, at 05:32:36PM, Jonathan (Zhixiong) Zhang wrote: >> From: "Jonathan (Zhixiong) Zhang" >> >> x86 and ia64 implement efi_mem_attributes() differently. This >> function needs to be available for other arch (such as arm64) >> as well, such as for the purpose of ACPI/APEI. >> >> ia64 efi does not setup memmap variable and does not set >> EFI_MEMMAP flag, so it needs to have its unique implementation >> of efi_mem_attributes(). >> >> Move efi_mem_attributes() implementation from x86 to efi, and >> declare it with __weak. It is recommended that other archs >> should not override the default implementation. >> >> Signed-off-by: Jonathan (Zhixiong) Zhang >> --- >> arch/x86/platform/efi/efi.c | 18 ------------------ >> drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++ >> 2 files changed, 31 insertions(+), 18 deletions(-) > > Reviewed-by: Matt Fleming > -- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/