Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbbGVSL6 (ORCPT ); Wed, 22 Jul 2015 14:11:58 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33722 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbbGVSLz (ORCPT ); Wed, 22 Jul 2015 14:11:55 -0400 Subject: Re: [PATCH v3 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 To: Chunfeng Yun , Mathias Nyman References: <1437573945-31586-1-git-send-email-chunfeng.yun@mediatek.com> <1437573945-31586-6-git-send-email-chunfeng.yun@mediatek.com> Cc: Rob Herring , Mark Rutland , Matthias Brugger , Felipe Balbi , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin , Daniel Kurtz From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55AFDCE6.2060608@cogentembedded.com> Date: Wed, 22 Jul 2015 21:11:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1437573945-31586-6-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1840 Lines: 68 Hello. On 07/22/2015 05:05 PM, Chunfeng Yun wrote: > add xHCI and phy drivers for MT8173-EVB > Signed-off-by: Chunfeng Yun > --- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 ++++++++++++++ > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 31 +++++++++++++++++++++++++++++ > 2 files changed, 46 insertions(+) > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > index f433c21..202b2b9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > @@ -13,6 +13,7 @@ > */ > > /dts-v1/; > +#include > #include "mt8173.dtsi" > > / { > @@ -32,6 +33,15 @@ > }; > > chosen { }; > + > + usb_p1_vbus: fixedregulator@0 { Just "regulator@0" please. This is more in line with what ePAPR requires from the node names. > + compatible = "regulator-fixed"; > + regulator-name = "usb_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > }; > > &pwrap { [...] > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 0696f8f..aa1ecc7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi [...] > @@ -393,6 +394,36 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + usb: usb30@11270000 { ePAPR standardizes the name "usb" for such nodes, please fix. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/