Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753201AbbGVVun (ORCPT ); Wed, 22 Jul 2015 17:50:43 -0400 Received: from gloria.sntech.de ([95.129.55.99]:54840 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbbGVVum (ORCPT ); Wed, 22 Jul 2015 17:50:42 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Mark Yao Cc: dri-devel@lists.freedesktop.org, David Airlie , Daniel Kurtz , Philipp Zabel , Daniel Vetter , Rob Clark , tfiga@chromium.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, sandy.huang@rock-chips.com, dkm@rock-chips.com, zwl@rock-chips.com, xw@rock-chips.com Subject: Re: [PATCH v3 4/6] drm/rockchip: vop: Default enable win2/3 area0 bit Date: Wed, 22 Jul 2015 23:50:32 +0200 Message-ID: <2715023.mZMEgdW6y4@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1437467140-13881-1-git-send-email-mark.yao@rock-chips.com> References: <1437466807-13689-1-git-send-email-mark.yao@rock-chips.com> <1437467140-13881-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1851 Lines: 54 Am Dienstag, 21. Juli 2015, 16:25:40 schrieb Mark Yao: > Win2/3 support multiple area function, but we haven't found > a suitable way to use it yet, so let's just use them as other windows > with only area 0 enabled. > > Signed-off-by: Mark Yao this could go as fix into 4.2 please. With what is currently in 4.2-rc3 I'm loosing the mouse cursor in my xf86- armsoc xserver [0]. Likely due to 0915da7dd75f ("drm/rockchip: vop: remove hardware cursor window"). The xserver then selects a window for the cursor itself, which seems to be one of the currently disabled ones. This patch fixes this and gives me back my cursor :-) Heiko [0] https://github.com/mmind/xf86-video-armsoc/tree/devel/rockchip > --- > Changes in v3: > Adviced by Tomasz Figa > - fix patch comments. > Changes in v2: None > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 47ce943..e08f318 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -276,6 +276,12 @@ static const struct vop_reg_data vop_init_reg_table[] = > { {DSP_CTRL0, 0x00000000}, > {WIN0_CTRL0, 0x00000080}, > {WIN1_CTRL0, 0x00000080}, > + /* TODO: Win2/3 support multiple area function, but we haven't found > + * a suitable way to use it yet, so let's just use them as other windows > + * with only area 0 enabled. > + */ > + {WIN2_CTRL0, 0x00000010}, > + {WIN3_CTRL0, 0x00000010}, > }; > > /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/