Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbbGVVvE (ORCPT ); Wed, 22 Jul 2015 17:51:04 -0400 Received: from [89.191.203.168] ([89.191.203.168]:49009 "EHLO mail.emea.novell.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752890AbbGVVvB (ORCPT ); Wed, 22 Jul 2015 17:51:01 -0400 Date: Wed, 22 Jul 2015 23:50:35 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Pavel Machek cc: Vlastimil Babka , Dmitry Torokhov , Samuel Thibault , =?ISO-8859-15?Q?Pali_Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman Subject: Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs In-Reply-To: <20150722214739.GA15790@amd> Message-ID: References: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> <1433799790-31873-2-git-send-email-dmitry.torokhov@gmail.com> <20150609174211.GH6338@dtor-ws> <55AE299F.3010002@suse.cz> <20150721170133.GA39076@dtor-ws> <55AFAB9B.2090101@suse.cz> <20150722214739.GA15790@amd> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 31 On Wed, 22 Jul 2015, Pavel Machek wrote: > > I am however not sure whether input_leds_connect() is not too unkind to > > unnamed LEDs and shouldn't be more tolerant to those in the long term. > > Maybe. > > > From: Jiri Kosina > > Subject: [PATCH] Input: leds: don't attempt to deregister unnamed LEDs > > > > input_leds_connect() is skipping registration of LEDs for which > > there is no symbolic name in input_led_info[]. > > Yes, and rather than testing for "no name" special case at two places, > what about simply giving up when we see such error? Well, that's quite the oposite of the "be more tolerant" aproach proposed above :) I don't see a reason why the sole fact that the device has at least one LED that kernel can't handle properly should mean that neither of the other LEDs will work. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/