Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006AbbGVWa6 (ORCPT ); Wed, 22 Jul 2015 18:30:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51910 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbbGVWa4 (ORCPT ); Wed, 22 Jul 2015 18:30:56 -0400 Date: Wed, 22 Jul 2015 15:30:55 -0700 From: Andrew Morton To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Dave Hansen , Naoya Horiguchi , David Rientjes , Hugh Dickins , Davidlohr Bueso , Aneesh Kumar , Hillf Danton , Christoph Hellwig , Michal Hocko Subject: Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() Message-Id: <20150722153055.7431aeb4c39dadf02ca06d4c@linux-foundation.org> In-Reply-To: <55B017EE.5020203@oracle.com> References: <1437502184-14269-1-git-send-email-mike.kravetz@oracle.com> <1437502184-14269-10-git-send-email-mike.kravetz@oracle.com> <20150722150345.f8d5b0042cfa7112bd95d9ef@linux-foundation.org> <55B017EE.5020203@oracle.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 29 On Wed, 22 Jul 2015 15:23:42 -0700 Mike Kravetz wrote: > On 07/22/2015 03:03 PM, Andrew Morton wrote: > > On Tue, 21 Jul 2015 11:09:43 -0700 Mike Kravetz wrote: > ... > >> + > >> + if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) > >> + return -EOPNOTSUPP; > > > > EOPNOTSUPP is a networking thing. It's inappropriate here. > > > > The problem is that if this error is ever returned to userspace, the > > user will be sitting looking at "Operation not supported on transport > > endpoint" and wondering what went wrong in the networking stack. > > Trying to follow FALLOCATE(2) man page: > > "EOPNOTSUPP > The filesystem containing the file referred to by fd does not > support this operation; or the mode is not supported by the > filesystem containing the file referred to by fd." > Sigh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/